[feature] Limit consecutive SMS tokens #481 #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/481-limit-sms-tokens
branch
from
63a3a9e
to
202d328
Compare
pandafy
commented
Jul 26, 2023
.github/workflows/ci.yml
Outdated
| @@ -53,6 +53,7 @@ jobs: | |||
| run: | | |||
| pip install -e .[saml,openvpn_status] | |||
| pip install ${{ matrix.django-version }} | |||
| pip install --force-reinstall --no-deps "https://github.com/openwisp/openwisp-utils/tarball/fallback-positiveintegerfield" | |||
There was a problem hiding this comment.
TODO: Remove this before merging.
There was a problem hiding this comment.
you can switch back to master
2 tasks
pandafy
force-pushed
the
issues/481-limit-sms-tokens
branch
from
202d328
to
8ffd9c5
Compare
nemesifier
requested changes
Jul 26, 2023
.github/workflows/ci.yml
Outdated
| @@ -53,6 +53,7 @@ jobs: | |||
| run: | | |||
| pip install -e .[saml,openvpn_status] | |||
| pip install ${{ matrix.django-version }} | |||
| pip install --force-reinstall --no-deps "https://github.com/openwisp/openwisp-utils/tarball/fallback-positiveintegerfield" | |||
There was a problem hiding this comment.
you can switch back to master
docs/source/user/settings.rst
Outdated
| which have :ref:`enabled the SMS verification option | ||
| <openwisp_radius_sms_verification_enabled>`. | ||
|
|
||
| ``OPENWISP_RADIUS_SMS_REQUEST_TIMEOUT`` |
There was a problem hiding this comment.
Time out is not a good name for this.
I would change it to OPENWISP_RADIUS_SMS_COOLDOWN.
openwisp_radius/admin.py
Outdated
| @@ -571,6 +571,7 @@ class OrganizationRadiusSettingsInline(admin.StackedInline): | |||
| 'sms_sender', | |||
| 'sms_message', | |||
| 'allowed_mobile_prefixes', | |||
| 'sms_timeout', | |||
openwisp_radius/base/models.py
Outdated
| @@ -1109,6 +1110,16 @@ class AbstractOrganizationRadiusSettings(UUIDModel): | |||
| ), | |||
| fallback=app_settings.SMS_MESSAGE_TEMPLATE, | |||
| ) | |||
| sms_timeout = FallbackPositiveIntegerField( | |||
nemesifier
requested changes
Jul 31, 2023
|
|
||
| This setting is applicable only for organizations | ||
| which have :ref:`enabled the SMS verification option | ||
| <openwisp_radius_sms_verification_enabled>`. |
There was a problem hiding this comment.
is this note referred to OPENWISP_RADIUS_SMS_COOLDOWN? If so, please move it after the heading, not before.
There was a problem hiding this comment.
This note is for OPENWISP_RADIUS_ALLOWED_MOBILE_PREFIXES
nemesifier
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #481
Blockers