Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Extended OPENWISP_USERS_EXPORT_USERS_COMMAND_CONFIG #486

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jul 26, 2023

Added 'registered_user.method' and 'registed_user.is_verified' to OPENWISP_USERS_EXPORT_USERS_COMMAND_CONFIG setting.

Blockers

@@ -45,6 +45,7 @@ jobs:
run: |
pip install -U pip wheel setuptools
pip install -U -r requirements-test.txt
pip install -U --force-reinstall --no-deps https://github.com/openwisp/openwisp-users/tarball/issues/355-command-line-utility
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove before merging

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please proceed.

@pandafy pandafy force-pushed the export-user branch 2 times, most recently from e602034 to 49b6e15 Compare August 2, 2023 16:09
Added 'registered_user.method' and 'registed_user.is_verified'
to OPENWISP_USERS_EXPORT_USERS_COMMAND_CONFIG setting.
@coveralls
Copy link

coveralls commented Aug 2, 2023

Coverage Status

coverage: 98.819% (+0.002%) from 98.817% when pulling fc5b1b9 on export-user into 6f31d23 on master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, let's wait until the PR which is depended upon is merged and we can then rollback the ci.yml change and merge this too.

@nemesifier nemesifier merged commit 889cf2d into master Aug 18, 2023
20 checks passed
@nemesifier nemesifier deleted the export-user branch August 18, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants