Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added all the shared logic #2

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Added all the shared logic #2

merged 1 commit into from
Jun 26, 2017

Conversation

rohithasrk
Copy link
Contributor

Added all the shared code as mentioned in #1. All I have to do is write tests now. I can start writing them but I've not figured out writing modular tests yet, i.e., for ex., A test case for MultitenantAdminMixin which can be extended.

@rohithasrk rohithasrk self-assigned this Jun 22, 2017
nemesifier
nemesifier approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address my inline comment and then proceed

openwisp_utils/tests/utils.py Outdated
user_model = get_user_model()


class TestAdminMixin(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename it to TestMultitenantAdminMixin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Okay

@coveralls
Copy link

coveralls commented Jun 23, 2017 •
edited

Coverage Status

Changes Unknown when pulling 89f55f6 on rohithasrk:testing into ** on openwisp:master**.

nemesifier
nemesifier approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash/Fixup the commits and then push to master, regarding the missing tests I will open a new issue because it requires some thought.

nemesifier
nemesifier reviewed Jun 26, 2017
View reviewed changes
tests/test_project/__init__.py Outdated
@@ -0,0 +1,3 @@
__dependencies__ = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d7a6f6a on rohithasrk:testing into ** on openwisp:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d7a6f6a on rohithasrk:testing into ** on openwisp:master**.

@coveralls
Copy link

coveralls commented Jun 26, 2017 •
edited

Coverage Status

Changes Unknown when pulling eceb5ec on rohithasrk:testing into ** on openwisp:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d24e486 on rohithasrk:testing into ** on openwisp:master**.

@rohithasrk rohithasrk force-pushed the testing branch 2 times, most recently from 7ea04e2 to 0082347 Compare June 26, 2017 13:17
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0082347 on rohithasrk:testing into ** on openwisp:master**.

@rohithasrk rohithasrk force-pushed the testing branch 3 times, most recently from 33c055d to c1df183 Compare June 26, 2017 18:22
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c1df183 on rohithasrk:testing into ** on openwisp:master**.

nemesifier
nemesifier requested changes Jun 26, 2017
View reviewed changes
tests/test_project/tests/test_staticfinders.py
class TestStaticFinders(unittest.TestCase):
def test_dependency_finder(self):
finder = DependencyFinder()
self.assertIsInstance(finder.locations, list)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to self.assertIn('django_netjsonconfig', finder.locations[0][1]) and do something similar for DependencyLoader

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@coveralls
Copy link

coveralls commented Jun 26, 2017 •
edited

Coverage Status

Changes Unknown when pulling 7847944 on rohithasrk:testing into ** on openwisp:master**.

@nemesifier
Copy link
Member

@rohithasrk yes

@coveralls
Copy link

coveralls commented Jun 26, 2017 •
edited

Coverage Status

Changes Unknown when pulling 3c8ca0a on rohithasrk:testing into ** on openwisp:master**.

@rohithasrk rohithasrk merged commit 70a702f into openwisp:master Jun 26, 2017
@rohithasrk rohithasrk deleted the testing branch June 26, 2017 20:36
@rohithasrk rohithasrk changed the title Added the basic outline of the project Added all the shared logic Jun 26, 2017
@rohithasrk rohithasrk mentioned this pull request Jun 26, 2017
Closed
ppabcd referenced this pull request in ppabcd/openwisp-utils Nov 22, 2018
@ppabcd
[qa] Updated unit testing #2
6794908 
Fixes #2
ppabcd referenced this pull request in ppabcd/openwisp-utils Nov 22, 2018
@ppabcd
[qa] Updated qa unit testing
f7c74a3 
Fixing #2
ppabcd referenced this pull request in ppabcd/openwisp-utils Nov 22, 2018
@ppabcd
[qa] Updated qa.py #2
2419fad
ppabcd referenced this pull request in ppabcd/openwisp-utils Nov 22, 2018
@ppabcd
[qa] Rollback #2
a1e96e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier requested changes

Assignees

@rohithasrk rohithasrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohithasrk @coveralls @nemesifier