[fix] Fixed several minor issues in retryable requests #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nemesifier
commented
Mar 14, 2024
nemesifier
commented
- we need to ensure a recent version of requests is installed
- docs had several mistakes
- some code was repeated twice in the function definition
- we need to ensure a recent version of requests is installed - docs had several mistakes - some code was repeated twice in the function definition
nemesifier
force-pushed
the
fix-retryable
branch
from
1dfff29
to
81d8e7a
Compare
pandafy
reviewed
Mar 14, 2024
| @@ -46,6 +46,8 @@ | |||
| 'django-compress-staticfiles~=1.0.1b', | |||
| 'django-admin-autocomplete-filter~=0.7.1', | |||
| 'swapper~=1.3.0', | |||
| # allow wider range here to avoid interfering with other modules | |||
| 'requests>=2.31.0,<3.0.0', | |||
There was a problem hiding this comment.
Do we need an upper limit here?
There was a problem hiding this comment.
just to avoid potential issues in the future, we can change it when the new version will be released
pandafy
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.