[change] Send OS details in all event categories #371 #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed "OS details" as a separate category - There are only three supported categories - Install, Upgrade and Heartbeat - Refactored code Closes #371
pandafy
force-pushed
the
issues/371-metric-collection-refactoring
branch
from
f991218
to
b75a42a
Compare
nemesifier
reviewed
Mar 22, 2024
nemesifier
requested changes
Apr 1, 2024
There was a problem hiding this comment.
I am testing this from an instance as follows:
from openwisp_utils.measurements.tasks import send_usage_metrics
send_usage_metrics.delay()
send_usage_metrics.delay(category='Heartbeat')
send_usage_metrics(category='Heartbeat')I see no events being collected.
Are you sure this is working as expected?
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
nemesifier
approved these changes
Apr 4, 2024
OpenWISP Priorities for next releases
automation
moved this from In progress
to Reviewer approved
Apr 4, 2024
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #371
Changes
Screenshots
Checklist