Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wifi-login-pages] Implement change phone number for active users #106

Closed
4 tasks
nemesifier opened this issue Nov 16, 2020 · 2 comments · Fixed by #118
Closed
4 tasks

[wifi-login-pages] Implement change phone number for active users #106

nemesifier opened this issue Nov 16, 2020 · 2 comments · Fixed by #118
Assignees
Labels
enhancement New feature or request Important

Comments

@nemesifier
Copy link
Member

nemesifier commented Nov 16, 2020

To be done after openwisp/openwisp-radius#179 is resolved.

This app has a change phone number component which is meant for inactive users to change their phone number, in case they mistakenly used a wrong phone number during registration.

  • we have to change the component so it allows verified users to use it, right now active users get redirected to status
  • add a test for the functionality described in the previous point
  • we have to ensure the whole flow works:
    • change phone number generates a new SMS token, flags user as inactive and user is redirected to mobile verification component
    • once user confirms the SMS token, it's flagged as active again, their phone number is correctly updated and is redirected to status component
  • change the org config generator so that if mobile_phone_verification is enabled, a link to change phone number is added to the header links (shown only to authenticated users)
@nemesifier nemesifier added enhancement New feature or request Important labels Nov 16, 2020
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Nov 16, 2020
@NoumbissiValere NoumbissiValere self-assigned this Nov 17, 2020
@NoumbissiValere
Copy link
Contributor

NoumbissiValere commented Nov 17, 2020

@nemesisdesign when you say verified users you meant active users right? If so, then there is a problem. During the development of PR #183, I sited that with the present implementations in openwisp-radius, active users can't change phone number because of this if statement and I opted to change it but you refused. So if we want to have this feature here, I will need to address this issue. and I can preferably do this in PR #183

@nemesifier
Copy link
Member Author

I hope the next steps are clear after our exchange, in short: both active and inactive users need to be able to change their phone number, but if an active user does this, it's flagged as inactive again until they confirm their new phone number and the old phone number is stored in the database (in the PhoneToken model). The work to do in this app should be small since the component is already developed, I just added a point (I forgot to make it explicit that we need a test) to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Important
Development

Successfully merging a pull request may close this issue.

2 participants