Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Password with eye icon #263

Closed
nemesifier opened this issue Jun 5, 2021 · 0 comments · Fixed by #264
Closed

[feature] Password with eye icon #263

nemesifier opened this issue Jun 5, 2021 · 0 comments · Fixed by #264
Assignees
@codesankalp
Labels
enhancement New feature or request
Projects
OpenWISP Contributor's Board OpenWISP Priorities for next releases [GSoC 2021] wifi-login-pages

Comments

@nemesifier
Copy link
Member

On mobile devices dealing with the password fields can be annoying, we could create a simple component that handles this, or reuse a third party solution (provided it's lightweight, eg: https://github.com/psd8/react-password-toggle-icon).

We could then use this component in:

  • login
  • registration
  • change password
  • confirm reset password
@nemesifier nemesifier added the enhancement New feature or request label Jun 5, 2021
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Jun 5, 2021
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Jun 5, 2021
@codesankalp codesankalp mentioned this issue Jun 7, 2021
Merged
@codesankalp codesankalp self-assigned this Jun 7, 2021
@codesankalp codesankalp added this to To do in [GSoC 2021] wifi-login-pages via automation Jun 7, 2021
@codesankalp codesankalp moved this from To do to In progress in [GSoC 2021] wifi-login-pages Jun 7, 2021
OpenWISP Contributor's Board automation moved this from To do (general) to Done Jun 8, 2021
nemesifier pushed a commit that referenced this issue Jun 8, 2021
@codesankalp
[feature] Added password reveal feature #263
402f915 
Added eye icons in all password fields to reveal or hide password.

Closes #263
OpenWISP Priorities for next releases automation moved this from Backlog to Done Jun 8, 2021
[GSoC 2021] wifi-login-pages automation moved this from In progress to Done Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codesankalp codesankalp

Labels
enhancement New feature or request
Projects
OpenWISP Contributor's Board
  
Done
OpenWISP Priorities for next releases
  
Done
[GSoC 2021] wifi-login-pages
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature] Password with eye icon openwisp/openwisp-wifi-login-pages
2 participants
@nemesifier @codesankalp