[feature] Added server side logging #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
May 22, 2021
There was a problem hiding this comment.
I think by default we should do:
- log level:
debugif development,warningif production (as you did) but should be possible to override this in some way (env var? what's the best practice here?) - output: console by default, but should be possible to configure it (following the same method that we'l chose for log level) to a different transport
Can we log HTTP requests by default during dev?
Please also add information to the README on how to override logging configuration.
codesankalp
moved this from In progress
to Review in progress
in [GSoC 2021] wifi-login-pages
nemesifier
reviewed
May 24, 2021
|
|
||
| | Environment Variable | Detail | | ||
| | -------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | **LOG_LEVEL** | (optional) This can be used to set the level of logging. The available values are `warn` and `debug`. By default log level is set to `debug` during development and `warn` during production. | |
There was a problem hiding this comment.
The available values are
warnanddebug.
What about info and error?
|
Please open the PR from a branch of this repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
Tasks done: