Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Changed is_verified to default to null #270 #271

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[fix] Changed is_verified to default to null #270 #271

merged 1 commit into from
Jun 16, 2021

Conversation

nemesifier
Copy link
Member

Fixes #270

@nemesifier nemesifier added the bug Something isn't working label Jun 14, 2021
@nemesifier nemesifier self-assigned this Jun 14, 2021
@nemesifier nemesifier added this to In progress in [GSoC 2021] wifi-login-pages via automation Jun 14, 2021
@nemesifier nemesifier mentioned this pull request Jun 14, 2021
Closed
[GSoC 2021] wifi-login-pages automation moved this from In progress to Reviewer approved Jun 15, 2021
codesankalp
codesankalp approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@codesankalp codesankalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally,
Working fine on mobile verification needed organization and default organization.

@nemesifier nemesifier merged commit fe06699 into master Jun 16, 2021
[GSoC 2021] wifi-login-pages automation moved this from Reviewer approved to Done Jun 16, 2021
@nemesifier nemesifier deleted the issues/270-is-verified-defaults-to-true branch June 16, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codesankalp codesankalp codesankalp approved these changes

Assignees

@nemesifier nemesifier

Labels
bug Something isn't working
Projects
No open projects
[GSoC 2021] wifi-login-pages
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] is_verified defaults to true
2 participants
@nemesifier @codesankalp