Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Update dependencies #42 #43

Merged
merged 1 commit into from
Jan 2, 2020
Merged

[Dependency] Update dependencies #42 #43

merged 1 commit into from
Jan 2, 2020

Conversation

nikitaermishin
Copy link
Contributor

This is PR for commit which updates outdated dependencies. Changes:

  • Updated dependencies according to Libraries.io
  • Added self-closing-component issue fix for modal.js and contact.js
  • Made snapshot update (due to update of react-router-dom and jest)

Notes:

  • didn't update eslint-config-airbnb because it needs code fix: check jsx-props-no-spreading and jsx-fragments rules for additional information
  • Libraries.io should be added from Openwisp account to this repo. On Libraries.io you should login, then go to Repository monitoring(libraries.io/repositories) and press Monitor.
  • Also I didn't find badge of Libraries.io, please note if it exists.
  • During testing process met following issues (web console):
    • Warning: Encountered two children with the same key, #
    • Warning: componentWillMount has been renamed, and is not recommended for use.

This issues should be fixed.

Fixes #42

This commit updates outdated dependencies. Changes:
 - Updated dependencies according to `Libraries.io`
 - Added `self-closing-component` issue fix for `modal.js` and `contact.js`
 - Made snapshot update (due to update of `react-router-dom` and `jest`)
 - Added `Libraries.io` badge for `readme.md`

Fixes #42
@Vivekrajput20 Vivekrajput20 merged commit 3402215 into openwisp:master Jan 2, 2020
@nikitaermishin
Copy link
Contributor Author

@Vivekrajput20 @nemesisdesign Also should mention, that badge will work after Libraries.io will be connected (check Notes part 2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wifi-login-pages] Add dependency monitoring and upgrade dependencies
2 participants