Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Replace set-output with GITHUB_OUTPUT in CI workflow #696

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

Shiva953
Copy link
Contributor

Fixes #669
This PR updates the CI workflow to replace the deprecated set-output commands with the new GITHUB_OUTPUT aligning with the latest changes in GitHub Actions.

Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shiva953, it looks good! Can you please provide a link to documentation regarding guidance migrating from the v2 to the v3 so we can double check?

@Shiva953
Copy link
Contributor Author

Thanks @Shiva953, it looks good! Can you please provide a link to documentation regarding guidance migrating from the v2 to the v3 so we can double check?

These might be helpful
https://blog.eidinger.info/why-and-how-to-adopt-actionscheckoutv3-in-your-github-action-workflow
https://action-slack.netlify.app/migration/01-migrate-from-v2-to-v3/

@Shiva953
Copy link
Contributor Author

@nemesifier any updates?

@nemesifier nemesifier changed the title [ci]Replace set-output with GITHUB_OUTPUT in CI workflow [ci] Replace set-output with GITHUB_OUTPUT in CI workflow Feb 14, 2024
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I lost this one from my radar, it should be good, what do you think @pandafy?
If you could rebase this on the latest master it would be helpful.

Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shiva953 there's even v4 released now which used Node 20 as run-time.

https://github.com/actions/checkout/releases

Also, your linked pages were not very helpful. While mentioning any changes to underlying software, always provide references from the author (here GitHub) instead of articles.

E.g. I found this GitHub Blog for deprecation of set-output-name.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@Shiva953
Copy link
Contributor Author

Shiva953 commented Feb 21, 2024

@Shiva953 there's even v4 released now which used Node 20 as run-time.

https://github.com/actions/checkout/releases

Also, your linked pages were not very helpful. While mentioning any changes to underlying software, always provide references from the author (here GitHub) instead of articles.

E.g. I found this GitHub Blog for deprecation of set-output-name. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

got it, should I update it to v4 now? or it wouldn't make sense to update it manually each time

@Shiva953
Copy link
Contributor Author

Shiva953 commented Mar 5, 2024

@pandafy any updates on this?

@nemesifier
Copy link
Member

Also, your linked pages were not very helpful. While mentioning any changes to underlying software, always provide references from the author (here GitHub) instead of articles.

If you can that would be useful, so you can go ahead and update.

This commit updates the actions version from v3 to v4.

Related to openwisp#669
@Shiva953
Copy link
Contributor Author

Also, your linked pages were not very helpful. While mentioning any changes to underlying software, always provide references from the author (here GitHub) instead of articles.

If you can that would be useful, so you can go ahead and update.

done.

@nemesifier nemesifier merged commit d5a5ad8 into openwisp:master Mar 11, 2024
3 checks passed
@nemesifier
Copy link
Member

Thanks @Shiva953 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Replace set-output in CI build
3 participants