-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Replace set-output with GITHUB_OUTPUT in CI workflow #696
Conversation
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shiva953, it looks good! Can you please provide a link to documentation regarding guidance migrating from the v2 to the v3 so we can double check?
These might be helpful |
@nemesifier any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I lost this one from my radar, it should be good, what do you think @pandafy?
If you could rebase this on the latest master it would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shiva953 there's even v4 released now which used Node 20 as run-time.
https://github.com/actions/checkout/releases
Also, your linked pages were not very helpful. While mentioning any changes to underlying software, always provide references from the author (here GitHub) instead of articles.
E.g. I found this GitHub Blog for deprecation of set-output-name
.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
got it, should I update it to v4 now? or it wouldn't make sense to update it manually each time |
@pandafy any updates on this? |
If you can that would be useful, so you can go ahead and update. |
This commit updates the actions version from v3 to v4. Related to openwisp#669
done. |
Thanks @Shiva953 👍 |
Fixes #669
This PR updates the CI workflow to replace the deprecated
set-output
commands with the newGITHUB_OUTPUT
aligning with the latest changes in GitHub Actions.