Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Skip adding empty DHCP lease tables #129

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

nemesifier
Copy link
Member

The DHCP lease code may add empty DHCP lease objects (tables in LUA) which are rejected by the schema validation of the OpenWISP Monitoring REST API.

@nemesifier nemesifier added the bug Something isn't working label Jan 17, 2024
@nemesifier nemesifier self-assigned this Jan 17, 2024
@nemesifier nemesifier added this to In progress in OpenWISP Priorities for next releases via automation Jan 17, 2024
Copy link

Pull Request Test Coverage Report for Build 7562224756

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 99.72%

Totals Coverage Status
Change from base Build 6337873467: -0.06%
Covered Lines: 3206
Relevant Lines: 3215

💛 - Coveralls

@nemesifier nemesifier merged commit dcf0b7d into master Jan 18, 2024
2 checks passed
OpenWISP Priorities for next releases automation moved this from In progress to Done Jan 18, 2024
@nemesifier nemesifier deleted the fix-dhcp-lease-irregular branch January 18, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

1 participant