Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python version to 3.10 and use slim image #373

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

magneticflux-
Copy link
Contributor

Closes #372

Signed-off-by: Mitchell Skaggs skaggsm333@gmail.com

Signed-off-by: Mitchell Skaggs <skaggsm333@gmail.com>
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #373 (041f9a5) into master (6f96889) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          13       13           
  Lines        1054     1054           
=======================================
  Hits          884      884           
  Misses        170      170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f96889...041f9a5. Read the comment docs.

@aparcar
Copy link
Member

aparcar commented Jul 28, 2022

Thanks, problem is that current worker images are using the official openwrt/imagebuilder container which uses an old Python version. Using a newer Python version comes with a different Pickle version which is used to communicate by rq.

I think there is an option for rq to explicitly use the "old" pickle format, could you please check that out?

build@7074cb0a47da:~/openwrt$ python3
Python 3.7.3 (default, Jan 22 2021, 20:04:44) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 

@magneticflux-
Copy link
Contributor Author

Unfortunately there is no such option for clients of RQ without patching it ourselves: rq/rq#1168

I could make a PR on Gitlab here to update from Buster to Bullseye (Debian 10 to 11): https://gitlab.com/openwrt/docker/-/blob/master/Dockerfile.base#L1. Buster's default Python3 is 3.7, but Bullseye's default is 3.9. However, this also updates GCC from 8.3 to 10.2.

@aparcar
Copy link
Member

aparcar commented Jul 28, 2022

I created a PR to upgrade the ImageBuilders, let's see if it works. If that's not an option we could also switch to the JSON serializer, however I'm not sure if that slows down things.

@aparcar
Copy link
Member

aparcar commented Jul 29, 2022

I updated the imagebuilder container, this should work now.

@aparcar aparcar merged commit 0ca7466 into openwrt:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Janitor uses Python 3.8 features but Docker images aren't updated past 3.7
2 participants