replace BRANCH with VERSION #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aparcar
force-pushed
the
version
branch
2 times, most recently
from
ef649ff
to
a532b88
Compare
The generate_targets.sh script requires to run on a specific branch to only generate jobs for existing targets. The BRANCH variable was however used for VERSION rather than the branch running on. This changes the behaviour by automatically selecting the correct branch and only taking the new VERSION env variable into account. By doing so new Docker container tags include `snapshot` rather than `master`, however for compatibility with existing setups the `master` tag is still added. Signed-off-by: Paul Spooren <mail@aparcar.org>
ynezz
approved these changes
Sep 11, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generate_targets.sh script requires to run on a specific branch to
only generate jobs for existing targets. The BRANCH variable was however
used for VERSION rather than the branch running on.
This changes the behaviour by automatically selecting the correct branch
and only taking the new VERSION env variable into account.
By doing so new Docker container tags include
snapshotrather thanmaster, however for compatibility with existing setups themastertag is still added.
Signed-off-by: Paul Spooren mail@aparcar.org