Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-firewall: cannot use multiple ports for the same rule #1637

Closed
luizluca opened this issue Feb 21, 2018 · 4 comments
Closed

luci-app-firewall: cannot use multiple ports for the same rule #1637

luizluca opened this issue Feb 21, 2018 · 4 comments

Comments

@luizluca
Copy link
Contributor

On LEDE 17.01.4:

UCI and fw3 accepts rules like:

config rule
        option enabled '1'
        option target 'ACCEPT'
        option proto 'tcp'
        option name 'adm open'
        option src 'lan'
        option src_ip '10.1.1.0/24'
        list dest_port '80'
        list dest_port '22'

LuCI even already shows it nicely in "Traffic rules" tables as "To any router IP at ports 80, 22 on this device"

However, the "Edit Rule" view only allows one port. It simply shows the first port (in case, 80). If I change port 80 to 81, LuCI changes the port entries from "list" to "option", remove all existing port references and use only the new port (81).

@luizluca
Copy link
Contributor Author

The same goes for src_ip.

@EricLuehrsen
Copy link
Contributor

Either "_port" option can be entered as a space separated lists. That is one work around at least. The "_ip" options do not work this way though.

@jow-
Copy link
Contributor

jow- commented May 7, 2018

Will take care of it soon (tm) - I promise. The main hurdle here is the lack of suitable widgets. The rule detail forms are a huge mess already and I need to think about a way to structure them better.

jow- added a commit to jow-/luci that referenced this issue Jun 19, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 20, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 22, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 22, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 22, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit to jow-/luci that referenced this issue Jun 22, 2018
 - allow multiple src/dest ips for rules (openwrt#1637)
 - restrict ICMP type list to ICMP protocol
 - add section title callbacks
 - remove size annotations

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@jow- jow- closed this as completed in 5142e40 Jun 22, 2018
@luizluca
Copy link
Contributor Author

Thanks @jow-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants