Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-app-statistics: ICMP drop rate "10000.00 %" (ping plugin) #3308

Closed
fantom-x opened this issue Nov 14, 2019 · 8 comments
Closed

luci-app-statistics: ICMP drop rate "10000.00 %" (ping plugin) #3308

fantom-x opened this issue Nov 14, 2019 · 8 comments
Labels
probably a bug issue could be a bug release/19.07 (end-of-support) issue on branch 19.07

Comments

@fantom-x
Copy link
Contributor

19.07-SNAPSHOT

That happens when all pings to a target are failing.

image
@feckert
Copy link
Member

feckert commented Nov 14, 2019

I think this has todo with the following pullrequest
openwrt/packages#9677

and commit

9def6fa#diff-eb03a4159d003171324a4a68d718b6ba

needs more investigation

@feckert feckert added probably a bug issue could be a bug release/19.07 (end-of-support) issue on branch 19.07 labels Nov 14, 2019
@yousong
Copy link
Member

yousong commented Nov 14, 2019

The two pull request were targeted for master branch of each repo. But it seems luci openwrt-19.07 branch forked after the luci-app-staticstics change got merged.

@yousong
Copy link
Member

yousong commented Nov 14, 2019 •
edited

Probably caused by the merge commit 2f61ab6 .

If we plan to preserve validity of data collectd by current openwrt-19.07 collectd, we need to revert the change on luci-app-statistics for current luci openwrt-19.07 branch. But the switch is already there in master branch and will be part of next release anyway.

I think we should backport openwrt/packages#9677 to openwrt-19.07. Ping @hnyman and @jow-

@jow-
Copy link
Contributor

jow- commented Nov 14, 2019

@yousong - fine with me. Can you take care of the collectd backport?

@yousong
Copy link
Member

yousong commented Nov 14, 2019

Will do.

yousong added a commit to openwrt/packages that referenced this issue Nov 14, 2019
@yousong
collectd: remove the patch scaling ping_droprate from 0-1 to 0-100
2a64b3a 
Upstream project's behaviour of reporting this data source in range 0-1
is used by at least CentOS 7 collectd 5.8.1, very likely the same
behaviour is also in widely use by other distributions.

The change is important for providing consistent experience across
collectd deployments on different environments

Ref: collectd/collectd#3244
Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
(cherry picked from commit 2f66fa5)
Ref: openwrt/luci#3308
@yousong
Copy link
Member

yousong commented Nov 15, 2019

@fantom-x collectd-mod-ping_5.9.0-3 should be starting to be available in the repo. Please consider giving it a try and report back.

@fantom-x
Copy link
Contributor Author

Yup, it show 100% now. Thx.

@yousong yousong closed this as completed Nov 16, 2019
@yousong
Copy link
Member

yousong commented Nov 16, 2019

Thanks for lettig us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
probably a bug issue could be a bug release/19.07 (end-of-support) issue on branch 19.07
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@feckert @jow- @yousong @fantom-x