Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19.07.3 regression: installing an app doesn't show in the menu unless logging out/in again #4077

Closed
jonglezb opened this issue May 20, 2020 · 6 comments
Labels
release/19.07 (end-of-support) issue on branch 19.07

Comments

@jonglezb
Copy link

In 19.07.2, after installing a LuCI app, it started appearing in the menu as soon as you go to a new page.

In 19.07.3, the new app doesn't appear in the menu even after changing page. A logout and login is needed.

I tried the bootstrap theme and the following apps:

  • luci-app-openvpn
  • luci-app-nlbwmon

To reproduce:

  • log in
  • go to System / Software
  • update lists
  • install luci-app-nlbwmon
  • go to (for instance) Status / Overview
  • the "Bandwidth Monitor" menu still does not appear
  • log out / log in : the menu now appears as expected
@jow-
Copy link
Contributor

jow- commented May 20, 2020

Yep, its a known issue which we cannot fix for 19.07.3 anymore. I added a note to the release notes. A fix will entail an update to luci-app-opkg which will flush the SessionStorage menu cache after a package install operation.

@singalen
Copy link

singalen commented May 23, 2020

A workaround helped me:

/etc/init.d/uhttpd stop
rm -rf /tmp/luci-*
/etc/init.d/uhttpd start

@zorun
Copy link

zorun commented Jul 6, 2020

Would it be enough to backport the (secondary) fix from dc57e4b ?

@jow-
Copy link
Contributor

jow- commented Jul 17, 2020

@zorun - yes, most likely. Not entirely sure if we'd need further backports in the dispatcher code wrt. server side cache invalidation

zorun pushed a commit to zorun/luci that referenced this issue Aug 30, 2020
This is a partial backport of dc57e4b

Fixes: openwrt#4077

Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org>
@zorun
Copy link

zorun commented Aug 30, 2020

It turns out that simply backporting the fix is enough, see #4402

aparcar pushed a commit that referenced this issue Sep 3, 2020
This is a partial backport of dc57e4b

Fixes: #4077

Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org>
@zorun
Copy link

zorun commented Sep 3, 2020

The fix is merged, thanks jow!

@jonglezb jonglezb closed this as completed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/19.07 (end-of-support) issue on branch 19.07
Projects
None yet
Development

No branches or pull requests

5 participants