You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First raised in #4150 which resolved custom ddns not completely working, however this issue still remains.
Issue
Create new Custom DDNS provider
Save the config
go back to the ddns screen
click edit
The displayed configuration now defaults to provider showing 3322.org (first in the list) you need to change it back to custom before save.
I believe the problem is here, A custom DNS provider does not have a defined service_name UCI attribute as such it cannot return/display "-- custom --"
The "-- custom --" variable is added to the list manually and is not defined as a service_name in uci config.
o.value('-',"-- " + _("custom") + " --");
Need to if uci.get return nothing then display custom. This may or may not work as not sure if there are other exceptions that could be broken by returning custom only when no service_name is found.
The text was updated successfully, but these errors were encountered:
Ansuel
added a commit
to Ansuel/luci
that referenced
this issue
Aug 22, 2020
If custom service is selected, no service is actually set in the uci config.
Fallback to custom service if no service is detected in the config.
Fixesopenwrt#4301
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
First raised in #4150 which resolved custom ddns not completely working, however this issue still remains.
Issue
Create new Custom DDNS provider
Save the config
go back to the ddns screen
click edit
The displayed configuration now defaults to provider showing 3322.org (first in the list) you need to change it back to custom before save.
I believe the problem is here, A custom DNS provider does not have a defined service_name UCI attribute as such it cannot return/display "-- custom --"
The "-- custom --" variable is added to the list manually and is not defined as a service_name in uci config.
o.value('-',"-- " + _("custom") + " --");
Need to if uci.get return nothing then display custom. This may or may not work as not sure if there are other exceptions that could be broken by returning custom only when no service_name is found.
The text was updated successfully, but these errors were encountered: