Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-ddns - customer dns provider config defaults to 3322.org #4301

Closed
mavack opened this issue Jul 28, 2020 · 0 comments · Fixed by #4380
Closed

luci-app-ddns - customer dns provider config defaults to 3322.org #4301

mavack opened this issue Jul 28, 2020 · 0 comments · Fixed by #4380

Comments

@mavack
Copy link

mavack commented Jul 28, 2020

First raised in #4150 which resolved custom ddns not completely working, however this issue still remains.

Issue
Create new Custom DDNS provider
Save the config
go back to the ddns screen
click edit
The displayed configuration now defaults to provider showing 3322.org (first in the list) you need to change it back to custom before save.

I believe the problem is here, A custom DNS provider does not have a defined service_name UCI attribute as such it cannot return/display "-- custom --"

o.cfgvalue = function(section_id) {
	return uci.get('ddns', section_id, 'service_name');
}

The "-- custom --" variable is added to the list manually and is not defined as a service_name in uci config.
o.value('-',"-- " + _("custom") + " --");

Need to if uci.get return nothing then display custom. This may or may not work as not sure if there are other exceptions that could be broken by returning custom only when no service_name is found.

Ansuel added a commit to Ansuel/luci that referenced this issue Aug 22, 2020
If custom service is selected, no service is actually set in the uci config.
Fallback to custom service if no service is detected in the config.

Fixes openwrt#4301

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant