Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcd-mod-luci: pull dhcp leases from all lease files #4308

Closed
wants to merge 2 commits into from

Conversation

aaronjg
Copy link
Contributor

@aaronjg aaronjg commented Jul 29, 2020

Fixes: #4303

rpcd mod currently only opens one lease file for each of dnsmasq/odhcpd. With this patch, it will open all the files that uci shows.

maintainer: @jow-
compiled with: openwrt-sdk-19.07.3-ipq806x-generic_gcc-7.5.0_musl_eabi.Linux-x86_64

Signed-off-by: Aaron Goodman aaronjg@stanford.edu

Signed-off-by: Aaron Goodman <aaronjg@stanford.edu>
Signed-off-by: Aaron Goodman <aaronjg@stanford.edu>
@aaronjg
Copy link
Contributor Author

aaronjg commented Aug 19, 2020

Also fixes #911 (of which #4303 is a dup)

@aaronjg
Copy link
Contributor Author

aaronjg commented Sep 10, 2020

@jow- Could you take a look at this? I just tested it again on 19.07.4, and it is still working.

@aaronjg
Copy link
Contributor Author

aaronjg commented Nov 5, 2020

@jow- Could you take a look or assign a reviewer please?

jow- added a commit that referenced this pull request Nov 6, 2020
Fixes: #911, #4303, #4308
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@jow-
Copy link
Contributor

jow- commented Nov 6, 2020

Fixed via 0c7a335

@jow- jow- closed this Nov 6, 2020
jow- added a commit that referenced this pull request Nov 6, 2020
Fixes: #911, #4303, #4308
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 0c7a335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpcd-mod-luci: only reports active leases from one dnsmasq server
2 participants