Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-proto-bonding is not compatible with bonding.sh #4473

Closed
qiuzi opened this issue Sep 26, 2020 · 4 comments · Fixed by openwrt/packages#15379
Closed

luci-proto-bonding is not compatible with bonding.sh #4473

qiuzi opened this issue Sep 26, 2020 · 4 comments · Fixed by openwrt/packages#15379

Comments

@qiuzi
Copy link
Contributor

qiuzi commented Sep 26, 2020 

option slaves'eth2' can be correctly identified

list slaves'eth2' is not recognized
@ghost
Copy link

ghost commented Sep 28, 2020

@qiuzi
Your problem seems to be the same or similar as I encountered some time ago and I opened an issue for this (openwrt/packages#11455). But as you can see there I made a workaround which should work.

Do you have some more information for me what happens at yours (in the LuCi or during execution of the shell script, ...), which version do you use, your current branch, ...

Regards

@qiuzi
Copy link
Contributor Author

qiuzi commented Sep 28, 2020

@he-ma
My method is to change "form.MultiValuev" to "form.Value"

//o.validate = updatePrimaries;

@ghost
Copy link

ghost commented Sep 28, 2020 •
edited by ghost

@qiuzi
Unfortunately, I cannot follow you.
For what reason did you alter the code?
What are you going to do?
Can you give me an example?
Have you read my issue?
What exactly is not working?

@qiuzi
Copy link
Contributor Author

qiuzi commented Sep 28, 2020

@he-ma At this stage, no case can support the variables of the "list" table
Only manually write "eth1 eth2"
So it is more appropriate to change the source code of luci
https://github.com/openwrt/luci/blob/master/protocols/luci-proto-bonding/htdocs/luci-static/resources/protocol/bonding.js#L177

jow- added a commit to jow-/packages that referenced this issue Apr 9, 2021
@jow-
bonding: accept list of slaves in uci list notation
7957c42 
Rework the bonding.sh protocol handler to accept slave interface names
encoded in uci list notation. Also replace ifconfig up/down with ip
link calls while we're at it.

Fixes: openwrt#11455
Fixes: openwrt/luci#4473
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@jow- jow- mentioned this issue Apr 9, 2021
Merged
jow- added a commit to jow-/packages that referenced this issue Apr 9, 2021
@jow-
bonding: accept list of slaves in uci list notation
57a7738 
Rework the bonding.sh protocol handler to accept slave interface names
encoded in uci list notation. Also replace ifconfig up/down with ip
link calls while we're at it.

Fixes: openwrt#11455
Fixes: openwrt/luci#4473
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
feckert pushed a commit to openwrt/packages that referenced this issue Apr 13, 2021
@jow- @feckert
bonding: accept list of slaves in uci list notation
1a16954 
Rework the bonding.sh protocol handler to accept slave interface names
encoded in uci list notation. Also replace ifconfig up/down with ip
link calls while we're at it.

Fixes: #11455
Fixes: openwrt/luci#4473
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 57a7738)
ja-pa pushed a commit to ja-pa/packages that referenced this issue Apr 20, 2021
@jow- @ja-pa
bonding: accept list of slaves in uci list notation
c8df021 
Rework the bonding.sh protocol handler to accept slave interface names
encoded in uci list notation. Also replace ifconfig up/down with ip
link calls while we're at it.

Fixes: openwrt#11455
Fixes: openwrt/luci#4473
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
utoni pushed a commit to utoni/openwrt-packages that referenced this issue May 11, 2021
@jow- @utoni
bonding: accept list of slaves in uci list notation
879241b 
Rework the bonding.sh protocol handler to accept slave interface names
encoded in uci list notation. Also replace ifconfig up/down with ip
link calls while we're at it.

Fixes: openwrt#11455
Fixes: openwrt/luci#4473
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bonding: accept list of slaves in uci list notation jow-/packages
1 participant
@qiuzi