Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token removal from URL causing problems #516

Closed
hnyman opened this issue Oct 21, 2015 · 7 comments
Closed

Token removal from URL causing problems #516

hnyman opened this issue Oct 21, 2015 · 7 comments

Comments

@hnyman
Copy link
Contributor

hnyman commented Oct 21, 2015

After the change in 86326e0 I can login ok with Firefox, but not with IE11. The browser remains on the login screen.

If a page address is entered manually, it works and also navigation afterwards.
e.g. https://192.168.1.1/cgi-bin/luci/admin/system/startup

So that sounds like a browser-specific problem on the login page redirecting functionality.
@hnyman hnyman mentioned this issue Oct 21, 2015
Closed
@Schabram
Copy link

Have the same problem with chrome but not after a reset change few thinks with LUCI and then locked out.

First login needed two trys.

@jow-
Copy link
Contributor

jow- commented Oct 21, 2015

Did you clear your browser caches to rule out redirects to stale urls and the like?

jow- added a commit that referenced this issue Oct 21, 2015
@jow-
luci-base: ensure that base url is emitted with trailing slash
79383f5 
Now that we don't have an url token anymore, '/cgi-bin/luci' becomes a valid
url while cookies are restricted to only '/cgi-bin/luci/' and below.

In order to ensure that the first request after login refers to a path
covered by the authentication cookie, change build_url() to always append
a trailing slash if we're referring to the base url.

This should fix the login problems mentioned in #516.

While we're touching the dispatcher, also remove remaining url token code.

Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
@Schabram
Copy link

Yes cleared , i test chrome last stable version with Windows and Linux google-chrome.
Only Firefox is a login possible

Jow your commit 79383f5 fix it.

@hnyman
Copy link
Contributor Author

hnyman commented Oct 21, 2015

I agree. I applied manually b4d62d3 and 79383f5 and login with IE11 works now ok.

@hnyman hnyman closed this as completed Oct 21, 2015
@hnyman
Copy link
Contributor Author

hnyman commented Oct 21, 2015

Hmmm. I am reusing this issue to report bad news:

I compiled a new version and tried to flash it, but flash window timeouts in the image upload & checksum calculation phase (after selecting firmware file and pressing "Flash image" button) with this error:

Bad Gateway
The process did not produce any response

Luci should be up-to-date, as I manually applied the two commits after the previous build.

It timeouts both in Firefox and in IE.

@hnyman hnyman changed the title Token removal from URL prevents login with IE11 Token removal from URL causing problems Oct 21, 2015
@hnyman hnyman reopened this Oct 21, 2015
@thess
Copy link
Member

thess commented Oct 21, 2015

I concur with this - flash upload hangs since last update. However, I can login OK now.

@hnyman
Copy link
Contributor Author

hnyman commented Oct 22, 2015

After 94ab57f flashing works again.
I close this ticket (again), but will leave #517 open for @kbabioch to verify and close.

@hnyman hnyman closed this as completed Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jow- @thess @hnyman @Schabram