Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add validation of least significant (mcast) via luci #5166

Closed
sla-te opened this issue Jul 3, 2021 · 0 comments
Closed

[ENHANCEMENT] Add validation of least significant (mcast) via luci #5166

sla-te opened this issue Jul 3, 2021 · 0 comments

Comments

@sla-te
Copy link

sla-te commented Jul 3, 2021

If an 'invalid' mac is being set via luci, the mac will be set but not actually applied to the interfaces. If we use generators, like: https://www.macvendorlookup.com/mac-address-generator or https://miniwebtool.com/de/mac-address-generator/ they might generate 'invalid' mac addresses and the user is not informed about it, assuming it is a bug.
@jow- jow- closed this as completed in 00e41c3 Jul 3, 2021
jow- added a commit that referenced this issue Jul 7, 2021
@jow-
luci-base: validation: disallow mutlicast MACs by default
1fed9af 
Extend the MAC address validator to disallow multicast MAC addresses and
add a new optional validator option to require multicast MACs instead of
unicast ones.

Fixes: #5166
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 00e41c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sla-te