Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port isolation on bridge interface sets the wrong value in config file #5383

Closed
lukts30 opened this issue Sep 23, 2021 · 0 comments
Closed

Comments

@lukts30
Copy link

lukts30 commented Sep 23, 2021

image
After enabling this setting the following command is executed: uci set network.cfg0a0f15.isolated='1'

Notice the d in isolated which is incorrect. netifd expects a config without a trailing d.
https://github.com/git-openwrt-org-mirror/netifd/blob/1eb0fafaa9865b729509a7d47ecf1f05c2c0595c/device.c#L57
After replacing isolated with isolate in the config file and reloading netifd the brport/isolate file has the expected value of 1.
Even though the setting in now correctly applied luci shows that the setting is not enabled since it still expects the incorrect named isolated.

o = this.replaceOption(s, 'brport', form.Flag, 'isolated', _('Port isolation'), _('Only allow communication with non-isolated bridge ports when enabled'));

tldr: luci should set isolate and not isolated


Previously reported: https://forum.openwrt.org/t/bridge-port-isolation-not-working/107168/1

@jow- jow- closed this as completed in e0053fe Sep 23, 2021
jow- added a commit that referenced this issue Sep 23, 2021
Fixes: #5383
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit e0053fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant