Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<luci>: Status -> Overview -> Active DHCP Leases: Table sort using header only lasts until next refresh (seconds) #6640

Closed
gb0101010101 opened this issue Oct 19, 2023 · 0 comments
Closed

<luci>: Status -> Overview -> Active DHCP Leases: Table sort using header only lasts until next refresh (seconds) #6640

gb0101010101 opened this issue Oct 19, 2023 · 0 comments

Comments

@gb0101010101
Copy link

Steps to reproduce:

  1. Go to router home page or Status -> Overview.
  2. Scroll down to table of Active DHCP Leases.
  3. Click on any of the table headings to sort table.
  4. Wait a few seconds for page to refresh, table sort reverts to default.

Actual behavior:

Table sort of Active DHCP Leases is lost and reverts to default view after a few seconds.

Expected behavior:

Table sort should be retained at least until page if fully reloaded.

Additional Information:

DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='22.03.2'
DISTRIB_REVISION='r19803-9a599fee93'
DISTRIB_TARGET='mvebu/cortexa9'
DISTRIB_ARCH='arm_cortex-a9_vfpv3-d16'
DISTRIB_DESCRIPTION='OpenWrt 22.03.2 r19803-9a599fee93'
DISTRIB_TAINTS=''
jow- added a commit that referenced this issue Oct 19, 2023
@jow-
luci-base: ui.js: sorting fixes for tables initialized from markup
ee6a4da 
 - Populate id option from table id attribute
 - Update column head sort indicator in UITable.update()
 - Don't store sort state for tables without id

Ref: #6640
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@jow- jow- closed this as completed in 6039925 Oct 19, 2023
jow- added a commit that referenced this issue Oct 19, 2023
@jow-
luci-base: ui.js: sorting fixes for tables initialized from markup
27fb6e5 
 - Populate id option from table id attribute
 - Update column head sort indicator in UITable.update()
 - Don't store sort state for tables without id

Ref: #6640
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit ee6a4da)
jow- added a commit that referenced this issue Oct 19, 2023
@jow-
luci-mod-status: persist sorting of DHCP lease status tables
9adda4a 
Add an ID attribute to the dynamically generated lease status tables to
persist row ordering choice across reloads.

Fixes: #6640
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 6039925)
jow- added a commit that referenced this issue Oct 19, 2023
@jow-
luci-base: ui.js: sorting fixes for tables initialized from markup
9f66674 
 - Populate id option from table id attribute
 - Update column head sort indicator in UITable.update()
 - Don't store sort state for tables without id

Ref: #6640
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit ee6a4da)
jow- added a commit that referenced this issue Oct 19, 2023
@jow-
luci-mod-status: persist sorting of DHCP lease status tables
20daafc 
Add an ID attribute to the dynamically generated lease status tables to
persist row ordering choice across reloads.

Fixes: #6640
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 6039925)
@gb0101010101 gb0101010101 mentioned this issue Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gb0101010101