luci-mod-admin-full: DHCP and DNS: Add fields for dnsmasq ipsets #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Mullally <jwmullally@gmail.com>
Signed-off-by: Joseph Mullally <jwmullally@gmail.com>
|
Tested on: Cases:
|
|
The only drawback I can see is if the blacklists are huge (100-1000s of rules) it would make using the page a pain. The solution for that would be to put it on a seperate tab. |
|
Please rebase your changes and please follow the contribution guidelines. |
|
No reaction from pullrequest creator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows easy user day-to-day administration of which domain IPs are added to IP Sets when dnsmasq is queried (useful for blacklists / whitelists).
Previously these domain lists could only be managed through the UI by using Domain Forwarding rules to a local ipset-dns instance, or by using third party packages (e.g. https://github.com/lvqier/luci-app-dnsmasq-ipset )
The IP Sets themselves and Firewall rules using them still need to be configured through uci.
This PR includes a necessary commit which simplifies the dnsmasq feature detection introduced in #679