freifunk-policyrouting: do not run init-script in imagebuilder #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating final images the build-scripts running the package init-scripts. As of including files like on a real system (line 4 and 5), with absolute path, this will fail. Activating init scripts build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/freifunk-policyrouting: line 4: /lib/functions/network.sh: No such file or directory build_dir/target-mips_24kc_musl/root-ar71xx/etc/init.d/freifunk-policyrouting: line 5: /lib/functions.sh: No such file or directory Running this init-script outside of a real-system don't seem to make sense at all, so just exit gracefully. Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
|
I think we might as well just remove the postinst script from the Makefile because it seems that OpenWrt now automatically enables init scripts on package install. @jow- can you confirm that? i'm a bit out of the loop. |
|
@jow any comment on this? |
|
I agree with @mmunz - let’s just remove the postinstall |
|
@SvenRoederer Please open a new pullrequest and remove the postinstall script mentioned by jow. |
|
after splitting the freifunk-packages into a separate feed, this issue became orphaned anyway and way open only as a reminder. |
SvenRoederer
added a commit
to freifunk/openwrt-packages
that referenced
this pull request
Jan 2, 2020
OpenWrt now enables the init-scripts be default, so there is no need to do this manually anymore. See: openwrt/luci#1635 (comment) Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
SvenRoederer
added a commit
to freifunk/openwrt-packages
that referenced
this pull request
Feb 16, 2020
OpenWrt now enables the init-scripts by default, so there is no need to do this manually anymore. See: openwrt/luci#1635 (comment) Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
SvenRoederer
added a commit
to freifunk/openwrt-packages
that referenced
this pull request
Feb 16, 2020
OpenWrt now enables the init-scripts by default, so there is no need to do this manually anymore. See: openwrt/luci#1635 (comment) Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating final images the build-scripts running the package init-scripts. As of including files like on a real system (line 4, 5), with absolute path, this will fail.
Running this init-script outside of a real-system don't seem to make sense at all, so just exit gracefully.