luci-app-opkg: made 'force-overwrite' user-driven/optional plus bugfix #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* made 'force-overwrite' flag optional, the user could set this like 'autoremove' today (see screenshots) * fix erroneously as 'installed' reported packages (happens whenever a package installation runs into an error) * add three dots to the first level 'Remove' button, cause it leads to a modal dialogue Signed-off-by: Dirk Brenken <dev@brenken.org>
|
New (default) workflow/result without force: New workflow with force: Maybe that's useful ... at least the 'installed' bug should be fixed. |
|
I think if a package is not installed it should not be part of the installed dictionary. The tests look like they paper over an underlying issue. |
|
I like this! :) Thank you. |
jow-
added a commit
that referenced
this pull request
Jun 19, 2019
Do not consider half-installed packages (which happens after an installation failure) to be installed. Ref: #2775 Signed-off-by: Dirk Brenken <dev@brenken.org> [split into multiple commits, refactored code, use local variables] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow-
added a commit
that referenced
this pull request
Jun 19, 2019
Add three dots to the first level 'Remove' button caption, because it leads to a modal dialogue. Ref: #2775 Signed-off-by: Dirk Brenken <dev@brenken.org> [split into multiple commits, sync translations] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow-
added a commit
that referenced
this pull request
Jun 19, 2019
Ref: #2775 Signed-off-by: Dirk Brenken <dev@brenken.org> [split into multiple commits, sync translations] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
Merged with some changes. Thanks @dibdot |
|
Would it be possible to include it also in OpenWrt 19.07? |
jow-
added a commit
that referenced
this pull request
Jun 24, 2019
Do not consider half-installed packages (which happens after an installation failure) to be installed. Ref: #2775 Signed-off-by: Dirk Brenken <dev@brenken.org> [split into multiple commits, refactored code, use local variables] Signed-off-by: Jo-Philipp Wich <jo@mein.io> (cherry picked from commit 88282c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like 'autoremove' today (see screenshots)
a package installation runs into an error)
leads to a modal dialogue
Signed-off-by: Dirk Brenken dev@brenken.org