Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-nextdns: add luci integration for nextdns package #3291

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

rs
Copy link
Contributor

@rs rs commented Nov 13, 2019

Signed-off-by: Olivier Poitrey rs@nextdns.io

Description:

Adding support for NextDNS, a DNS over HTTPS service that provides customized block-lists (ad-block, malware protection, kid safety) as well advanced analytics amongst other things.

Depends on: openwrt/packages#10535

Screen Shot 2019-11-12 at 6 29 40 PM

Screen Shot 2019-11-12 at 6 29 49 PM

Signed-off-by: Olivier Poitrey <rs@nextdns.io>
@feckert feckert added depends on other pr pull request depends on another pull request feature pull request adding a new feature labels Nov 13, 2019
@rs
Copy link
Contributor Author

rs commented Nov 15, 2019

FYI, main PR have been merged.

@ysc3839
Copy link
Contributor

ysc3839 commented Nov 15, 2019

I think you should use client-side implementation. If you don't know how to do that I can make a pull request.

@rs
Copy link
Contributor Author

rs commented Nov 15, 2019

@ysc3839: what do you mean by client-side implementation?

@ysc3839
Copy link
Contributor

ysc3839 commented Nov 15, 2019

@rs #3267

@rs
Copy link
Contributor Author

rs commented Nov 15, 2019

Got it. We can definitely move to client side, and we will. Could we do that in a second time tho? I'd love to have this module make the cut for 19.07.0 together with the daemon package which is already merged.

@hnyman
Copy link
Contributor

hnyman commented Nov 16, 2019

Let's merge this first. You can then convert it later.
(there is not that much computational/conditional logic in the app, so the client-side implementation would not decrease router's CPU load that much.)

@hnyman hnyman merged commit 2663c33 into openwrt:master Nov 16, 2019
@rs
Copy link
Contributor Author

rs commented Nov 16, 2019

Awesome, so you need another PR to put it in 19.07?

@hnyman
Copy link
Contributor

hnyman commented Nov 16, 2019

Yes, preferably.

But if quite identical code works for 19.07 (and you have tested it...), I can also cherry-pick your single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on other pr pull request depends on another pull request feature pull request adding a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants