Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC/RFT] themes: add new theme OpenWrt 2020 #3780

Merged
merged 1 commit into from Mar 27, 2020
Merged

[RFC/RFT] themes: add new theme OpenWrt 2020 #3780

merged 1 commit into from Mar 27, 2020

Conversation

jow-
Copy link
Contributor

@jow- jow- commented Mar 23, 2020 •
edited

Introduce a new theme modeled after the logo guidelines published in
https://openwrt.org/_media/docs/guide-graphic-designer/openwrt-logo-usage-guidelines.pdf

  • Requires 98a9d07 or later to work properly.
  • Tested on Firefox 73.0, Chrome 79.0, iPhone 6s iOS 13.3.1
  • No attempt was made to make it compatible with legacy browsers

A few screenshots below. Please ignore the german/english mixture, this is due to some localisation experiments.

Desktop
1
2
3
4
5

Mobile
m1
m2
m3
m4

@jow- jow- mentioned this pull request Mar 23, 2020
Open
@ysc3839
Copy link
Contributor

ysc3839 commented Mar 24, 2020

This one seems OK, but I still prefer Bootstrap or Material. However, it seems that it's hard to get Bootstrap works so maybe I would give up.

@jow- jow- force-pushed the theme-openwrt-2020 branch 3 times, most recently from 19d2bfd to a039017 Compare March 25, 2020 12:07
@jow-
themes: add new theme OpenWrt 2020
63b5f63 
Introduce a new theme modelled after the logo guidelines published in
https://openwrt.org/_media/docs/guide-graphic-designer/openwrt-logo-usage-guidelines.pdf

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@hnyman
Copy link
Contributor

hnyman commented Mar 26, 2020

I tested this in my local builds.
Seems good enough for merge.

(but with yesterday's commit the login button is black for some reason)
image

@jow-
Copy link
Contributor Author

jow- commented Mar 26, 2020

(but with yesterday's commit the login button is black for some reason)

On which browser did you observe the issue?

@hnyman
Copy link
Contributor

hnyman commented Mar 26, 2020

On which browser did you observe the issue?

Firefox 75.0b9 (64-bit)
Edge Version 80.0.361.69 (Official build) (64-bit)
Chrome Version 80.0.3987.149 (Official Build) (64-bit)

Could be some build error on my part, but I doubt.
Normally I use Firefox, but also tested this on Edge and Chrome after the error materialised in Firefox

@jow-
Copy link
Contributor Author

jow- commented Mar 26, 2020

Indeed, it seems that I forgot to push some changes. It is hopefully solved by 9edb933

@jow- jow- merged commit eed3edf into openwrt:master Mar 27, 2020
@jow- jow- deleted the theme-openwrt-2020 branch March 27, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jow- @ysc3839 @hnyman