luci-app-statistics: integrate collectd-mod-sqm #4181
Conversation
This patch makes it possible to enable and configure the SQM input plugin for collectd from the Luci front-end. It also handles the generation of the appropriate collectd configuration for the SQM plugin using the generic Exec plugin. Signed-off-by: Joe Nahmias <joe@nahmias.net>
Now that we can configure the SQM collectd plugin to run, this commit backports the SQM & SQM-Cake graph creation and display code from [master 9c4f345], while translating the javascript code to lua. Signed-off-by: Joe Nahmias <joe@nahmias.net>
|
One note for testing: you will have to create a dummy sqm module so that the template code doesn't skip this plugin. For example, you can run: |
|
Bump - do you have any feedback on this PR? is a review needed by anyone in particular? is there anything else I need to do in order for this to be merged? |
|
The way I see it you want to add this to the openwrt-19.07 branch. But this branch is already released, so only bug fixes should be added here. Especially since the hack with the so file is not good. |
|
The change required in collectd ("dummy sqm module") to make the LuCI stats menus work in 19.07 is the nasty part. That is the reason why I abandoned my own attempt earlier. I say the NAK for 19.07. Great that you got it for yourself, but lets leave the hack out of 19.07. |
This PR integrates the SQM collectd plugin into luci-app-statistics. It provides for both the configuration of the module, and the generation & display of the graphs from the collected data.
cc: @ldir-EDB0