luci-mod-status: use raw dsl values and format them ourselves #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jow-
reviewed
Dec 4, 2020
| if (s > 0) | ||
| return '%ds'.format(seconds); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
I think you can simply use the %t format here to shrink the code.
| if (bytes > 1000) | ||
| return '%.3f Kb/s'.format(bytes / 1000); | ||
| return '%d b/s'.format(bytes); | ||
| } |
There was a problem hiding this comment.
That entire function could be replaced by '%1000.3mb/s'.format(bytes)
Currently lantiq_dsl.sh performs these formats expensively in a shell script. Use the raw values so the preformatted onces can be removed to cut down the runtime or the script. Signed-off-by: Andre Heider <a.heider@gmail.com>
|
Thanks, that's much more simple (first time hacking on luci and js) |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lantiq_dsl.sh performs these formats expensively in a shell
script. Use the raw values so the preformatted onces can be removed to
cut down the runtime or the script.
Signed-off-by: Andre Heider a.heider@gmail.com