-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-mod-network: skip check for 802.11w feature #4689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenWrt commit 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT") enables 802.11w feature for all wpad/hostapd configurations. The feature flag was removed at all but for the compatibility reasons 11w is still advertised (but there's a plan to nuke it also) [1]. Remove conditional 802.11w LuCI support to match current behavior. [1]: openwrt/openwrt#3347 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com>
Thanks. Merged. |
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Jan 4, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com>
dobo90
added a commit
to dobo90/openwrt
that referenced
this pull request
May 24, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com>
jow-
pushed a commit
to openwrt/openwrt
that referenced
this pull request
Jun 21, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com> [remove outdated PKG_RELEASE bump and update to SPDX] Signed-off-by: Paul Spooren <mail@aparcar.org>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Jun 21, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com> [remove outdated PKG_RELEASE bump and update to SPDX] Signed-off-by: Paul Spooren <mail@aparcar.org>
coolsnowwolf
pushed a commit
to coolsnowwolf/lede
that referenced
this pull request
Jun 21, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com> [remove outdated PKG_RELEASE bump and update to SPDX] Signed-off-by: Paul Spooren <mail@aparcar.org>
1715173329
pushed a commit
to immortalwrt/immortalwrt
that referenced
this pull request
Jun 21, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com> [remove outdated PKG_RELEASE bump and update to SPDX] Signed-off-by: Paul Spooren <mail@aparcar.org> (cherry picked from commit bb2ac5a)
jollaman999
pushed a commit
to jollaman999/openwrt
that referenced
this pull request
Jun 24, 2021
This is a follow up of 1a9b896d ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com> [remove outdated PKG_RELEASE bump and update to SPDX] Signed-off-by: Paul Spooren <mail@aparcar.org>
maurerr
pushed a commit
to maurerr/openwrt
that referenced
this pull request
Sep 1, 2021
This is a follow up of 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT"). LuCI commit ab010406 ("luci-mod-network: skip check for 802.11w feature") skips check of the 11w feature [1]. Now advertising it in hostapd is superfluous so stop doing it. [1]: openwrt/luci#4689 Signed-off-by: Dobroslaw Kijowski <dobo90@gmail.com> [remove outdated PKG_RELEASE bump and update to SPDX] Signed-off-by: Paul Spooren <mail@aparcar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenWrt commit 1a9b896 ("treewide: nuke DRIVER_11W_SUPPORT") enables
802.11w feature for all wpad/hostapd configurations. The feature flag
was removed at all but for the compatibility reasons 11w is still
advertised (but there's a plan to nuke it also) 1.
Remove conditional 802.11w LuCI support to match current behavior.
Signed-off-by: Dobroslaw Kijowski dobo90@gmail.com