Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-network: add warning with weak security wirless Encryption #5890

Closed
wants to merge 1 commit into from

Conversation

Ansuel
Copy link
Member

@Ansuel Ansuel commented Jul 19, 2022

Add a warning if an user select a weak security wireless Encryption to
make him aware that he is using a vulnerable security mode.

Also demote WPA-PSK mixed mode to a weak security mode.

Signed-off-by: Christian Marangi ansuelsmth@gmail.com


This is the current design for this

image

Add a warning if an user select a weak security wireless Encryption to
make him aware that he is using a vulnerable security mode.

Also demote WPA-PSK mixed mode to a weak security mode.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
@Ansuel
Copy link
Member Author

Ansuel commented Jul 19, 2022

@jow- what do you think?

@jow-
Copy link
Contributor

jow- commented Jul 19, 2022

I already demoted WPA-PSK to low security. I do not like the banner message.

Edit: just noted that you applied the change to mixed mode, that is fine. But I do not like warning banner, it's also does not cover all potentential permutations (e.g. WPA(1)-PSK with AES only, WPA(1)-EAP with TKIP, WEP etc.)

So I'd say let's leave aside the banner and focus on labeling the select box choices properly.

@Ansuel
Copy link
Member Author

Ansuel commented Jul 19, 2022 via email

@jow-
Copy link
Contributor

jow- commented Jul 19, 2022

There's a billion potential settings to make your router insecure and we don't plaster warning banners for them everywhere.

@lynxthecat
Copy link

lynxthecat commented Jul 23, 2022

"A journey of a thousand miles begins with a single step"?

Also this is a setting that almost every user will actually set?

Or is this the creep factor for lots of unwanted and annoying feedback like the paper clip in Microsoft Office?

@Ansuel
Copy link
Member Author

Ansuel commented Jul 27, 2022

Closing this as not accepted.

@Ansuel Ansuel closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants