luci-mod-network: improve descriptions for DSL annex option values #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spell out the names of the DSL standards to make the options easier to understand. For modems supporting VDSL, also mention clearly which of the options actually set the bits for VDSL2. As the items now start with the name of an ADSL standard, use that for ordering. The generic variants including VDSL2 support stay at the top, as they should be a good choice in almost all cases. Signed-off-by: Jan Hoffmann <jan@3e8.eu>
|
Thanks! |
|
Also cherry-picked this to openwrt-23.05 8343c52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spell out the names of the DSL standards to make the options easier to understand. For modems supporting VDSL, also mention clearly which of the options actually set the bits for VDSL2.
As the items now start with the name of an ADSL standard, use that for ordering. The generic variants including VDSL2 support stay at the top, as they should be a good choice in almost all cases.
(I think ideally it would also be nice to highlight the first few options (especially the A/L/M and the B/J option) in some way, as one of those should be the right choice in almost all cases. But I'm not sure if there is good way to do that.)