Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to broadcast packet when using Etherwake #975

Closed
wants to merge 3 commits into from
Closed

Add option to broadcast packet when using Etherwake #975

wants to merge 3 commits into from

Conversation

jose1711
Copy link
Contributor

i need to supply -b to etherwake in order to make wol work. this adds this option to luci

@hnyman
Copy link
Contributor

hnyman commented Jan 27, 2017 •
edited

Several faults:

  • Three commits, two of them are unrelated, and one of them is a merge commit. You should not do stuff in master, instead use a new feature branch for each feature. It is much easier in the long run.
  • It does not work if the user has only etherwake installed (and etherwake is the default for this Luci app.) The reason is that you defined a dependency on option "binary", but "binary" is only set if both wol and etherwake are installed. Dependency needs to be reformulated.
  • And you have not signed-off your commit.

EDIT: wol is only in oldpackages, so that is really ancient.

hnyman added a commit to hnyman/luci that referenced this pull request Jan 27, 2017
@hnyman
luci-app-wol: add ability to send packet to broadcast address
16bbe45 
Add the ability to send the WOL packet to the broadcast address,
if etherwake is used as the wol tool.

Modified from the original idea in openwrt#975

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
@hnyman
Copy link
Contributor

hnyman commented Jan 27, 2017

Applied manually in a modified format with 16bbe45

(note that I also moved the app to the Services menu tab with c5b84f2 )

@hnyman hnyman closed this Jan 27, 2017
hafu pushed a commit to hafu/luci that referenced this pull request Feb 28, 2017
@hnyman @hafu
luci-app-wol: add ability to send packet to broadcast address
3b2b68a 
Add the ability to send the WOL packet to the broadcast address,
if etherwake is used as the wol tool.

Modified from the original idea in openwrt#975

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jose1711 @hnyman