Skip to content

Commit

Permalink
mt76: mt7663s: disable interrupt during txrx_worker processing
Browse files Browse the repository at this point in the history
In order to reduce sdio bus contention, disable interrupts during
txrx_worker processing

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
  • Loading branch information
LorenzoBianconi authored and nbd168 committed Sep 27, 2020
1 parent 75157b5 commit 6dc67b0
Showing 1 changed file with 9 additions and 18 deletions.
27 changes: 9 additions & 18 deletions mt7615/sdio_txrx.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,7 @@ static int mt7663s_rx_run_queue(struct mt76_dev *dev, enum mt76_rxq_id qid,

buf = page_address(page);

sdio_claim_host(sdio->func);
err = sdio_readsb(sdio->func, buf, MCR_WRDR(qid), len);
sdio_release_host(sdio->func);

if (err < 0) {
dev_err(dev->dev, "sdio read data failed:%d\n", err);
__free_pages(page, order);
Expand Down Expand Up @@ -144,14 +141,9 @@ static int mt7663s_rx_handler(struct mt76_dev *dev)
struct mt76s_intr *intr = sdio->intr_data;
int nframes = 0, ret;

/* disable interrupt */
sdio_claim_host(sdio->func);
sdio_writel(sdio->func, WHLPCR_INT_EN_CLR, MCR_WHLPCR, NULL);
ret = sdio_readsb(sdio->func, intr, MCR_WHISR, sizeof(*intr));
sdio_release_host(sdio->func);

if (ret < 0)
goto out;
return ret;

trace_dev_irq(dev, intr->isr, 0);

Expand All @@ -173,12 +165,6 @@ static int mt7663s_rx_handler(struct mt76_dev *dev)

nframes += !!mt7663s_refill_sched_quota(dev, intr->tx.wtqcr);

out:
/* enable interrupt */
sdio_claim_host(sdio->func);
sdio_writel(sdio->func, WHLPCR_INT_EN_SET, MCR_WHLPCR, NULL);
sdio_release_host(sdio->func);

return nframes;
}

Expand Down Expand Up @@ -225,10 +211,7 @@ static int __mt7663s_xmit_queue(struct mt76_dev *dev, u8 *data, int len)
if (len > sdio->func->cur_blksize)
len = roundup(len, sdio->func->cur_blksize);

sdio_claim_host(sdio->func);
err = sdio_writesb(sdio->func, MCR_WTDR1, data, len);
sdio_release_host(sdio->func);

if (err)
dev_err(dev->dev, "sdio write failed: %d\n", err);

Expand Down Expand Up @@ -298,6 +281,10 @@ void mt7663s_txrx_worker(struct mt76_worker *w)
struct mt76_dev *dev = container_of(sdio, struct mt76_dev, sdio);
int i, nframes, ret;

/* disable interrupt */
sdio_claim_host(sdio->func);
sdio_writel(sdio->func, WHLPCR_INT_EN_CLR, MCR_WHLPCR, NULL);

do {
nframes = 0;

Expand All @@ -313,6 +300,10 @@ void mt7663s_txrx_worker(struct mt76_worker *w)
if (ret > 0)
nframes += ret;
} while (nframes > 0);

/* enable interrupt */
sdio_writel(sdio->func, WHLPCR_INT_EN_SET, MCR_WHLPCR, NULL);
sdio_release_host(sdio->func);
}

void mt7663s_sdio_irq(struct sdio_func *func)
Expand Down

0 comments on commit 6dc67b0

Please sign in to comment.