Skip to content

Commit

Permalink
ath79: use ath10k-ct-smallbuffers for 64 MiB devices
Browse files Browse the repository at this point in the history
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
  • Loading branch information
paulfertser authored and hauke committed Dec 23, 2019
1 parent 80f06cb commit db992e7
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions target/linux/ath79/image/generic-tp-link.mk
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ define Device/tplink_archer-c2-v3
IMAGE_SIZE := 7808k
DEVICE_MODEL := Archer C2
DEVICE_VARIANT := v3
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9887-ct
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9887-ct
TPLINK_BOARD_ID := ARCHER-C2-V3
endef
TARGET_DEVICES += tplink_archer-c2-v3
Expand All @@ -32,7 +32,7 @@ define Device/tplink_archer-c25-v1
DEVICE_MODEL := Archer C25
DEVICE_VARIANT := v1
TPLINK_BOARD_ID := ARCHER-C25-V1
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9887-ct
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9887-ct
SUPPORTED_DEVICES += archer-c25-v1
endef
TARGET_DEVICES += tplink_archer-c25-v1
Expand All @@ -56,7 +56,7 @@ define Device/tplink_archer-c58-v1
DEVICE_MODEL := Archer C58
DEVICE_VARIANT := v1
TPLINK_BOARD_ID := ARCHER-C58-V1
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct
SUPPORTED_DEVICES += archer-c58-v1
endef
TARGET_DEVICES += tplink_archer-c58-v1
Expand Down Expand Up @@ -119,7 +119,7 @@ define Device/tplink_archer-c60-v1
DEVICE_MODEL := Archer C60
DEVICE_VARIANT := v1
TPLINK_BOARD_ID := ARCHER-C60-V1
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct
SUPPORTED_DEVICES += archer-c60-v1
endef
TARGET_DEVICES += tplink_archer-c60-v1
Expand All @@ -131,7 +131,7 @@ define Device/tplink_archer-c60-v2
DEVICE_MODEL := Archer C60
DEVICE_VARIANT := v2
TPLINK_BOARD_ID := ARCHER-C60-V2
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9888-ct
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct
SUPPORTED_DEVICES += archer-c60-v2
endef
TARGET_DEVICES += tplink_archer-c60-v2
Expand Down
10 changes: 5 additions & 5 deletions target/linux/ath79/image/generic-ubnt.mk
Original file line number Diff line number Diff line change
Expand Up @@ -122,36 +122,36 @@ define Device/ubnt_lap-120
$(Device/ubnt-wa)
DEVICE_MODEL := LiteAP ac
DEVICE_VARIANT := LAP-120
DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct
DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct
endef
TARGET_DEVICES += ubnt_lap-120

define Device/ubnt_litebeam-ac-gen2
$(Device/ubnt-wa)
DEVICE_MODEL := LiteBeam AC
DEVICE_VARIANT := Gen2
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca988x-ct
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct
endef
TARGET_DEVICES += ubnt_litebeam-ac-gen2

define Device/ubnt_nanobeam-ac
$(Device/ubnt-wa)
DEVICE_MODEL := NanoBeam AC
DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct rssileds
DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct rssileds
endef
TARGET_DEVICES += ubnt_nanobeam-ac

define Device/ubnt_nanostation-ac
$(Device/ubnt-wa)
DEVICE_MODEL := Nanostation AC
DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct rssileds
DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct rssileds
endef
TARGET_DEVICES += ubnt_nanostation-ac

define Device/ubnt_nanostation-ac-loco
$(Device/ubnt-wa)
DEVICE_MODEL := Nanostation AC loco
DEVICE_PACKAGES += kmod-ath10k-ct ath10k-firmware-qca988x-ct
DEVICE_PACKAGES += kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct
endef
TARGET_DEVICES += ubnt_nanostation-ac-loco

Expand Down
8 changes: 4 additions & 4 deletions target/linux/ath79/image/generic.mk
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ define Device/comfast_cf-e313ac
SOC := qca9531
DEVICE_VENDOR := COMFAST
DEVICE_MODEL := CF-E313AC
DEVICE_PACKAGES := rssileds kmod-leds-gpio kmod-ath10k-ct \
DEVICE_PACKAGES := rssileds kmod-leds-gpio kmod-ath10k-ct-smallbuffers \
ath10k-firmware-qca9888-ct -swconfig -uboot-envtools
IMAGE_SIZE := 7936k
endef
Expand Down Expand Up @@ -473,7 +473,7 @@ define Device/dlink_dir-859-a1
DEVICE_MODEL := DIR-859
DEVICE_VARIANT := A1
IMAGE_SIZE := 15872k
DEVICE_PACKAGES := kmod-usb2 kmod-ath10k-ct ath10k-firmware-qca988x-ct
DEVICE_PACKAGES := kmod-usb2 kmod-ath10k-ct-smallbuffers ath10k-firmware-qca988x-ct
SEAMA_SIGNATURE := wrgac37_dlink.2013gui_dir859
SUPPORTED_DEVICES += dir-859-a1
endef
Expand Down Expand Up @@ -719,7 +719,7 @@ define Device/nec_wg800hp
IMAGE/factory.bin := append-kernel | pad-to $$$$(BLOCKSIZE) | \
append-rootfs | pad-rootfs | check-size $$$$(IMAGE_SIZE) | \
xor-image -p 6A57190601121E4C004C1E1201061957 -x | nec-fw LASER_ATERM
DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9887-ct-htt
DEVICE_PACKAGES := kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9887-ct-htt
endef
TARGET_DEVICES += nec_wg800hp

Expand Down Expand Up @@ -917,7 +917,7 @@ define Device/phicomm_k2t
IMAGE_SIZE := 15744k
IMAGE/sysupgrade.bin := append-kernel | append-rootfs | pad-rootfs | \
append-metadata | check-size $$$$(IMAGE_SIZE)
DEVICE_PACKAGES := kmod-leds-reset kmod-ath10k-ct ath10k-firmware-qca9888-ct
DEVICE_PACKAGES := kmod-leds-reset kmod-ath10k-ct-smallbuffers ath10k-firmware-qca9888-ct
endef
TARGET_DEVICES += phicomm_k2t

Expand Down

7 comments on commit db992e7

@manjuprajna
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulfertser thank you. I think some ipq40xx devices also need to change. My Asus RT-ac58u (128MB memory) has same out of memory issue on both master and 1907 branch, while 1806 has no problem, same kernel only difference is ath10k-ct, when turn on wifi, rapidly run out of memory, after 3 to 5 minutes, even can't ssh login, like bricked.

@paulfertser
Copy link
Contributor Author

@paulfertser paulfertser commented on db992e7 Dec 24, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manjuprajna
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulfertser thank you so much!

@oldium
Copy link
Contributor

@oldium oldium commented on db992e7 Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean that when I had ping problems this morning on my Archer C7 v4 (ping over wifi had lost packets, while ping over lan was fine), it could be caused by out-of-memory for firmware? There was nothing in logread. What to check to be sure it is this out-of-memory thing? There was nothing in logread...

@paulfertser
Copy link
Contributor Author

@paulfertser paulfertser commented on db992e7 Dec 24, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulfertser
Copy link
Contributor Author

@paulfertser paulfertser commented on db992e7 Dec 24, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oldium
Copy link
Contributor

@oldium oldium commented on db992e7 Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently have no explanation for packet loss, so I am just guessing. Thanks for hint, anyway. Next time I will try to check memory somehow.

Please sign in to comment.