package/libs/wolfssl build fail on ipq807x #11866

ptpt52 · 2023-01-24T02:52:21Z

Describe the bug

build on ubuntu 18.04

ERROR: package/libs/wolfssl failed to build (build variant: cpu-crypto).

make V=s -j1 package/libs/wolfssl/compile

make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/scripts/config'
make[2]: 'conf' is up to date.
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/scripts/config'
make[1]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt'
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/toolchain'
echo "libc" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
echo "libgcc" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
echo "libpthread" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
echo "librt" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/toolchain'
time: package/libs/toolchain/compile#0.13#0.08#0.20
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/libtool'
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/libtool'
time: package/libs/libtool/compile#0.11#0.09#0.19
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
time: package/libs/wolfssl/regular/compile#0.21#0.11#0.30
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
Makefile:205: *** Invalid file operation: <preinst.arm-ce.  Stop.
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
time: package/libs/wolfssl/cpu-crypto/compile#0.19#0.09#0.26
    ERROR: package/libs/wolfssl failed to build (build variant: cpu-crypto).
package/Makefile:114: recipe for target 'package/libs/wolfssl/compile' failed
make[1]: *** [package/libs/wolfssl/compile] Error 1
make[1]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt'
/mnt/Data/Sources/openwrt/x-wrt/include/toplevel.mk:229: recipe for target 'package/libs/wolfssl/compile' failed
make: *** [package/libs/wolfssl/compile] Error 2

Also build failed on ubuntu 22.04:

Configuring libnfnetlink0.
Configuring iperf3.
Configuring wireless-tools.
Configuring urngd.
Configuring iftop.
Configuring luci-i18n-firewall-zh-cn.
Configuring 6to4.
Configuring ppp-mod-pppoe.
Collected errors:
 * check_data_file_clashes: Package libwolfsslcpu-crypto5.5.4.15181848 wants to install file /data/x-wrt/build_dir/target-aarch64_cortex-a53_musl/root-ipq807x/usr/lib/libwolfssl.so.5.5.4.15181848
        But that file is already provided by package  * libwolfssl5.5.4.15181848
 * opkg_install_cmd: Cannot install package libwolfsslcpu-crypto5.5.4.15181848.
make[2]: *** [package/Makefile:70: package/install] Error 255
make[2]: Leaving directory '/data/x-wrt'
make[1]: *** [package/Makefile:111: /data/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/stamp/.package_install] Error 2
make[1]: Leaving directory '/data/x-wrt'
make: *** [/data/x-wrt/include/toplevel.mk:231: world] Error 2

The text was updated successfully, but these errors were encountered:

ptpt52 · 2023-01-24T02:56:51Z

ping @cotequeiroz

xabolcs · 2023-01-24T06:38:54Z

Duplicate of #11839

ptpt52 · 2023-01-24T06:46:07Z

Duplicate of #11839

@xabolcs hi,
here I report 2 issue.

build failed on ubuntu 18.04, this looks like something wrong related to Makefile.
build on ubuntu 22.04 and this duplicate of Conflicts between libraries libwolfsslcpu-crypto and libwolfssl with imagebuilder #11839

robimarko · 2023-01-24T08:18:19Z

Please post the log with make -j1 V=s, I find it personally weird as I was building in CI on 22.04 for months and the CPU variant of wolfssl always built fine

ptpt52 · 2023-01-24T09:09:27Z

@robimarko it build fine on ubuntu 22.04, the pkg check_data_file_clashes could be ignored. cause by:

CONFIG_PACKAGE_libwolfsslcpu-crypto=y
CONFIG_PACKAGE_libwolfssl=m

the build fail issue on ubuntu 18.04 is really the problem.
make -j1 V=s log:

make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/scripts/config'
make[2]: 'conf' is up to date.
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/scripts/config'
make[1]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt'
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/toolchain'
echo "libc" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
echo "libgcc" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
echo "libpthread" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
echo "librt" >> /mnt/Data/Sources/openwrt/x-wrt/staging_dir/target-aarch64_cortex-a53_musl/pkginfo/toolchain.default.install
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/toolchain'
time: package/libs/toolchain/compile#0.13#0.08#0.20
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/libtool'
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/libtool'
time: package/libs/libtool/compile#0.11#0.09#0.19
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
time: package/libs/wolfssl/regular/compile#0.21#0.11#0.30
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
Makefile:205: *** Invalid file operation: <preinst.arm-ce.  Stop.
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
time: package/libs/wolfssl/cpu-crypto/compile#0.19#0.09#0.26
    ERROR: package/libs/wolfssl failed to build (build variant: cpu-crypto).
package/Makefile:114: recipe for target 'package/libs/wolfssl/compile' failed
make[1]: *** [package/libs/wolfssl/compile] Error 1
make[1]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt'
/mnt/Data/Sources/openwrt/x-wrt/include/toplevel.mk:229: recipe for target 'package/libs/wolfssl/compile' failed
make: *** [package/libs/wolfssl/compile] Error 2

robimarko · 2023-01-24T09:14:07Z

That is not from running with V=s for sure

ptpt52 · 2023-01-24T10:22:44Z

@robimarko
I try make V=s package/libs/wolfssl/clean
it also fail

make V=s package/libs/wolfssl/clean
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/scripts/config'
make[2]: 'conf' is up to date.
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/scripts/config'
make[1]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt'
make[2]: Entering directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
rm -rf /mnt/Data/Sources/openwrt/x-wrt/build_dir/target-aarch64_cortex-a53_musl/wolfssl-cpu-crypto/wolfssl-5.5.4-stable
Makefile:205: *** Invalid file operation: <preinst.arm-ce.  Stop.
make[2]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt/package/libs/wolfssl'
time: package/libs/wolfssl/cpu-crypto/clean#0.17#0.09#0.25
    ERROR: package/libs/wolfssl failed to build (build variant: cpu-crypto).
package/Makefile:114: recipe for target 'package/libs/wolfssl/clean' failed
make[1]: *** [package/libs/wolfssl/clean] Error 1
make[1]: Leaving directory '/mnt/Data/Sources/openwrt/x-wrt'
/mnt/Data/Sources/openwrt/x-wrt/include/toplevel.mk:229: recipe for target 'package/libs/wolfssl/clean' failed
make: *** [package/libs/wolfssl/clean] Error 2

robimarko · 2023-01-24T12:29:31Z

You were right, and I figured out the issue.
The issue is that make only got the ability to read from files with $(file <) in v4.2 but 18.04 ships make v4.1.
Confirmed by manually compiling v4.2 on 18.04 and using it, that works just fine.

No clue what is the pre 4.2 alternative

ptpt52 · 2023-01-24T12:56:03Z

@robimarko

would this work? use cat

diff --git a/package/libs/wolfssl/Makefile b/package/libs/wolfssl/Makefile
index 1500a2cda79..a870a8a5dcd 100644
--- a/package/libs/wolfssl/Makefile
+++ b/package/libs/wolfssl/Makefile
@@ -162,7 +162,7 @@ else ifdef CONFIG_aarch64
     TARGET_CFLAGS:=$(TARGET_CFLAGS:-mcpu%=-mcpu%+crypto)
     WOLFSSL_NOASM_REGEX:=^bcm27xx/.*
     Package/libwolfsslcpu-crypto/preinst=\
-       $(subst @@WOLFSSL_NOASM_REGEX@@,$(WOLFSSL_NOASM_REGEX),$(file <preinst.arm-ce))
+       $(subst @@WOLFSSL_NOASM_REGEX@@,$(WOLFSSL_NOASM_REGEX),$(shell cat preinst.arm-ce))
 else ifdef CONFIG_TARGET_x86_64
        CONFIGURE_ARGS += --enable-intelasm
 endif

robimarko · 2023-01-24T13:05:15Z

That will get it compiling, but I am not sure if the desired behaviour will be the same

ptpt52 · 2023-01-24T13:06:42Z

ping @nbd168

ptpt52 · 2023-01-24T13:07:43Z

ping @jow-

ptpt52 · 2023-01-25T06:44:43Z

x-wrt@c636901

I am trying to rewrite the Makefile to achieve the same goal

Fixes: openwrt#11866 Signed-off-by: Chen Minqiang <ptpt52@gmail.com>

Inline the preinst.arm-ce script. Support for including was added in make 4.2 and is not working with older make versions. Fixes: openwrt#11866 Signed-off-by: Chen Minqiang <ptpt52@gmail.com>

Inline the preinst.arm-ce script. Support for including was added in make 4.2 and is not working with older make versions. Fixes: openwrt/openwrt#11866 Signed-off-by: Chen Minqiang <ptpt52@gmail.com>

Inline the preinst.arm-ce script. Support for including was added in make 4.2 and is not working with older make versions. Fixes: openwrt/openwrt#11866 Signed-off-by: Chen Minqiang <ptpt52@gmail.com> (cherry picked from commit fcde517)

ptpt52 added the bug issue report with a confirmed bug label Jan 24, 2023

ptpt52 added a commit to x-wrt/x-wrt that referenced this issue Jan 26, 2023

wolfssl: fix build with make < 4.2

b65e7ec

Fixes: openwrt#11866 Signed-off-by: Chen Minqiang <ptpt52@gmail.com>

ptpt52 mentioned this issue Jan 26, 2023

wolfssl: fix build with make < 4.2 #11882

Closed

openwrt-bot closed this as completed in fcde517 Feb 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

package/libs/wolfssl build fail on ipq807x #11866

package/libs/wolfssl build fail on ipq807x #11866

ptpt52 commented Jan 24, 2023 •

edited

ptpt52 commented Jan 24, 2023

xabolcs commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023 •

edited

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

ptpt52 commented Jan 25, 2023

package/libs/wolfssl build fail on ipq807x #11866

package/libs/wolfssl build fail on ipq807x #11866

Comments

ptpt52 commented Jan 24, 2023 • edited

Describe the bug

Also build failed on ubuntu 22.04:

ptpt52 commented Jan 24, 2023

xabolcs commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023 • edited

ptpt52 commented Jan 24, 2023

robimarko commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

ptpt52 commented Jan 24, 2023

ptpt52 commented Jan 25, 2023

ptpt52 commented Jan 24, 2023 •

edited

robimarko commented Jan 24, 2023 •

edited