Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfssl: fix build with make < 4.2 #11882

Closed
wants to merge 1 commit into from
Closed

Conversation

ptpt52
Copy link
Contributor

@ptpt52 ptpt52 commented Jan 26, 2023

Fixes: #11866

Fixes: openwrt#11866

Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
@github-actions github-actions bot added the core packages pull request/issue for core (in-tree) packages label Jan 26, 2023
@robimarko
Copy link
Contributor

@cotequeiroz

Cannot $(shell) be used to evaluate the script as external file?

@cotequeiroz
Copy link
Member

cotequeiroz commented Jan 26, 2023

I'm on vacation now, so I won't be able to try it for a while. Testing is just s matter of comparing the script.
My original proposal was to inline the script, so if it does not work, you have another option. I don't think I still have the original commit, but it shouldn't be too bad.

There's one thing I would like to avoid: using makefile syntax inside a separate shell script file.

Edit: I've just realized this is inline the script.

@hauke
Copy link
Member

hauke commented Feb 3, 2023

Thank you for the patch, I added it to master in fcde517.
I extended the description a bit.

We should probably backport it to stable versions too.

@hauke hauke closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package/libs/wolfssl build fail on ipq807x
4 participants