Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: bump 5.15 to 5.15.116 #12823

Merged
merged 3 commits into from Jun 12, 2023
Merged

kernel: bump 5.15 to 5.15.116 #12823

merged 3 commits into from Jun 12, 2023

Conversation

graysky2
Copy link
Contributor

@graysky2 graysky2 commented Jun 5, 2023

All patches rebased automatically.

Build system: x86_64
Build-tested: ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

@github-actions github-actions bot added build/scripts/tools pull request/issues for build, scripts and tools related changes kernel pull request/issue with Linux kernel related changes labels Jun 5, 2023
@graysky2
Copy link
Contributor Author

graysky2 commented Jun 5, 2023

I am getting a build error with ramips/tplink_archer-a6-v3:

make[8]: Entering directory '/scratch/union/build_dir/target-mipsel_24kc_musl/linux-ramips_mt7621/linux-5.15.115'
  CC      drivers/net/dsa/mt7530.o
drivers/net/dsa/mt7530.c: In function 'mt7531_setup':
drivers/net/dsa/mt7530.c:2453:14: error: 'i' undeclared (first use in this function); did you mean 'id'?
 2453 |         for (i = 0; i < MT7530_NUM_PORTS; i++)
      |              ^
      |              id
drivers/net/dsa/mt7530.c:2453:14: note: each undeclared identifier is reported only once for each function it appears in
make[8]: *** [scripts/Makefile.build:289: drivers/net/dsa/mt7530.o] Error 1

@DragonBluep
Copy link
Contributor

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit?h=v5.15.115&id=5a7266feaa6d708fc6880a161786eaa884ef3c8e
In this patch, upstream version removes the variable i, but our local version still retains it.

@graysky2
Copy link
Contributor Author

graysky2 commented Jun 6, 2023

In this patch, upstream version removes the variable i, but our local version still retains it.

@DragonBluep - I don't understand, our local version was removed in this commit.
EDIT: maybe you are saying that I need to grep for this file in all other patches and modify the ones causing this change?

I don't have much time today, so any pointer is appreciated.

@DragonBluep
Copy link
Contributor

DragonBluep commented Jun 6, 2023

What I mean is the upstream merged patch is not exactly the same as our local patch so we can't fully remove it. There is a tiny difference about variable i. We need to add a new patch to redefine variable i.

upstream version:

 mt7531_setup(struct dsa_switch *ds)
 {
 	struct mt7530_priv *priv = ds->priv;
 	struct mt7530_dummy_poll p;
-	struct dsa_port *cpu_dp;
 	u32 val, id;
-	int ret, i;
+	int ret;

local version:

mt7531_setup(struct dsa_switch *ds)
{
struct mt7530_priv *priv = ds->priv;
struct mt7530_dummy_poll p;
- struct dsa_port *cpu_dp;
u32 val, id;
int ret, i;

edit:
or we can modify and define i in this patch:
https://github.com/openwrt/openwrt/blob/main/target/linux/generic/pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch

@graysky2
Copy link
Contributor Author

graysky2 commented Jun 6, 2023

Thanks for the suggestions. Built fine and seems to be running fine on ramips/tplink_archer-a6-v3 for me. Can you please review?

I was a bit confused because there are two sections that could fit the lines starting with /* Reset whole chip through gpio pin or memory-mapped registers for ... I placed the block in the one closest to the definition for i as you can see.

@DragonBluep
Copy link
Contributor

Tested on ath79, everything is fine. Most of the changes are related to the mt7531 switch. If mt7621 runs well, there's nothing to worry about.

@Borromini
Copy link

Borromini commented Jun 8, 2023

After a full day of homeworking, it looks like MT7621 is okay. Was tested on top of 23.05 HEAD but shouldn't matter much yet.

Compile-tested: ath79/generic, ipq40xx, octeon, ramips/mt76{20,21,x8}, realtek/rtl{838,930}x, mvebu/cortexa{9,72}, x86/64.
Run-tested: mt7621 (EAP615-Wall, WAX202), mvebu (RB5009UG+S+IN).

@CharlesMengCA
Copy link
Contributor

Linksys E8450 (UBI) Tested. Working fine.

@graysky2 graysky2 changed the title kernel: bump 5.15 to 5.15.115 kernel: bump 5.15 to 5.15.116 Jun 10, 2023
@github-actions github-actions bot added target/ath25 pull request/issue for ath25 target target/ath79 pull request/issue for ath79 target target/ramips pull request/issue for ramips target labels Jun 10, 2023
@Ansuel
Copy link
Member

Ansuel commented Jun 11, 2023

@graysky2 maybe some kernel modules to update?

@DragonBluep
Copy link
Contributor

@hauke - not sure why the error https://github.com/openwrt/openwrt/actions/runs/5231935142/jobs/9446653258?pr=12823#step:29:32

The missing symbol is CONFIG_DRM_RCAR_USE_LVDS

This is already set: https://github.com/openwrt/openwrt/blob/main/target/linux/generic/config-5.15#L1636
CONFIG_DRM_RCAR_LVDS

The existing one is CONFIG_DRM_RCAR_LVDS

They are different!

@zxlhhyccc
Copy link

@graysky2 graysky2 force-pushed the 5.15 branch 3 times, most recently from 6dd236f to 10327bd Compare June 11, 2023 19:04
Manually rebased:
	backport-5.15/603-v5.19-page_pool-Add-recycle-stats-to-page_pool_put_page_bu.patch
	pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch*

Removed upstreamed:
	generic-backport/610-v6.3-net-page_pool-use-in_softirq-instead.patch[1]
	backport-5.15/705-12-v6.0-net-dsa-mt7530-rework-mt753-01-_setup.patch[2]
	backport-5.15/790-v6.4-0010-net-dsa-mt7530-split-off-common-parts-from-mt7531_se.patch[3]
	backport-5.15/703-10-v5.16-net-dsa-introduce-helpers-for-iterating-through-port.patch[4]

All other patches automatically rebased.

* Modified to define the variable i as suggested by DragonBluep in PR discussion.
  See: openwrt#12823 (comment)

1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=3af319d5147454dc63665ef451229c674b538377
2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=0753c1ef24194580f7165ae6e259b59a851392f2
3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=5a7266feaa6d708fc6880a161786eaa884ef3c8e
4. gregkh/linux@9902f91

Build system: x86_64
Build-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

Signed-off-by: John Audia <therealgraysky@proton.me>
Added missing symbol.

Signed-off-by: John Audia <therealgraysky@proton.me>
All patches rebased automatically.

Build system: x86_64
Build-tested: ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

Signed-off-by: John Audia <therealgraysky@proton.me>
@openwrt-bot openwrt-bot merged commit 5dc78d8 into openwrt:main Jun 12, 2023
7 checks passed
kwiateusz pushed a commit to kwiateusz/openwrt that referenced this pull request Jun 14, 2023
Manually rebased:
	backport-5.15/603-v5.19-page_pool-Add-recycle-stats-to-page_pool_put_page_bu.patch
	pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch*

Removed upstreamed:
	generic-backport/610-v6.3-net-page_pool-use-in_softirq-instead.patch[1]
	backport-5.15/705-12-v6.0-net-dsa-mt7530-rework-mt753-01-_setup.patch[2]
	backport-5.15/790-v6.4-0010-net-dsa-mt7530-split-off-common-parts-from-mt7531_se.patch[3]
	backport-5.15/703-10-v5.16-net-dsa-introduce-helpers-for-iterating-through-port.patch[4]

All other patches automatically rebased.

* Modified to define the variable i as suggested by DragonBluep in PR discussion.
  See: openwrt#12823 (comment)

1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=3af319d5147454dc63665ef451229c674b538377
2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=0753c1ef24194580f7165ae6e259b59a851392f2
3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=5a7266feaa6d708fc6880a161786eaa884ef3c8e
4. gregkh/linux@9902f91

Build system: x86_64
Build-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

Signed-off-by: John Audia <therealgraysky@proton.me>
(cherry picked from commit 5714660)
@graysky2 graysky2 deleted the 5.15 branch June 14, 2023 21:09
hauke pushed a commit to hauke/openwrt that referenced this pull request Jun 17, 2023
Manually rebased:
	backport-5.15/603-v5.19-page_pool-Add-recycle-stats-to-page_pool_put_page_bu.patch
	pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch*

Removed upstreamed:
	generic-backport/610-v6.3-net-page_pool-use-in_softirq-instead.patch[1]
	backport-5.15/705-12-v6.0-net-dsa-mt7530-rework-mt753-01-_setup.patch[2]
	backport-5.15/790-v6.4-0010-net-dsa-mt7530-split-off-common-parts-from-mt7531_se.patch[3]
	backport-5.15/703-10-v5.16-net-dsa-introduce-helpers-for-iterating-through-port.patch[4]

All other patches automatically rebased.

* Modified to define the variable i as suggested by DragonBluep in PR discussion.
  See: openwrt#12823 (comment)

1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=3af319d5147454dc63665ef451229c674b538377
2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=0753c1ef24194580f7165ae6e259b59a851392f2
3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=5a7266feaa6d708fc6880a161786eaa884ef3c8e
4. gregkh/linux@9902f91

Build system: x86_64
Build-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

Signed-off-by: John Audia <therealgraysky@proton.me>
(cherry picked from commit 5714660)
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request Jun 27, 2023
Manually rebased:
	backport-5.15/603-v5.19-page_pool-Add-recycle-stats-to-page_pool_put_page_bu.patch
	pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch*

Removed upstreamed:
	generic-backport/610-v6.3-net-page_pool-use-in_softirq-instead.patch[1]
	backport-5.15/705-12-v6.0-net-dsa-mt7530-rework-mt753-01-_setup.patch[2]
	backport-5.15/790-v6.4-0010-net-dsa-mt7530-split-off-common-parts-from-mt7531_se.patch[3]
	backport-5.15/703-10-v5.16-net-dsa-introduce-helpers-for-iterating-through-port.patch[4]

All other patches automatically rebased.

* Modified to define the variable i as suggested by DragonBluep in PR discussion.
  See: openwrt#12823 (comment)

1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=3af319d5147454dc63665ef451229c674b538377
2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=0753c1ef24194580f7165ae6e259b59a851392f2
3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=5a7266feaa6d708fc6880a161786eaa884ef3c8e
4. gregkh/linux@9902f91

Build system: x86_64
Build-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

Signed-off-by: John Audia <therealgraysky@proton.me>
Mr-3S pushed a commit to Mr-3S/openwrt-nanopi-r6s that referenced this pull request Nov 24, 2023
Manually rebased:
	backport-5.15/603-v5.19-page_pool-Add-recycle-stats-to-page_pool_put_page_bu.patch
	pending-5.15/723-net-mt7531-ensure-all-MACs-are-powered-down-before-r.patch*

Removed upstreamed:
	generic-backport/610-v6.3-net-page_pool-use-in_softirq-instead.patch[1]
	backport-5.15/705-12-v6.0-net-dsa-mt7530-rework-mt753-01-_setup.patch[2]
	backport-5.15/790-v6.4-0010-net-dsa-mt7530-split-off-common-parts-from-mt7531_se.patch[3]
	backport-5.15/703-10-v5.16-net-dsa-introduce-helpers-for-iterating-through-port.patch[4]

All other patches automatically rebased.

* Modified to define the variable i as suggested by DragonBluep in PR discussion.
  See: openwrt/openwrt#12823 (comment)

1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=3af319d5147454dc63665ef451229c674b538377
2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=0753c1ef24194580f7165ae6e259b59a851392f2
3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.115&id=5a7266feaa6d708fc6880a161786eaa884ef3c8e
4. gregkh/linux@9902f91

Build system: x86_64
Build-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod
Run-tested: bcm2711/RPi4B, ramips/tplink_archer-a6-v3, filogic/xiaomi_redmi-router-ax6000-ubootmod

Signed-off-by: John Audia <therealgraysky@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/scripts/tools pull request/issues for build, scripts and tools related changes kernel pull request/issue with Linux kernel related changes target/ath25 pull request/issue for ath25 target target/ath79 pull request/issue for ath79 target target/ramips pull request/issue for ramips target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants