target: ipq806x: remove mac-address-increment

[neheb]

It's deprecated.

ping @rmilecki @Ansuel

[neheb]

ping @computersforpeace

[hnyman]

@neheb @Ansuel
cc @shelterx

Current r24586-f3cdc9f988 build for R7800 reads a wrong MAC address for wan, while lan ports and wlan do have the corrects MACs.

I suspect this commit, as it handles the MAC reading from flash.
R7800 / nighthawk reads wrongly MAC from 0x6, which code is changed slightly differently by defining "mac-base" than the other MAC definitions in nighthawk.dtsi.

Lan and wlan MACs are ok, but wan (eth0) MAC is wrong.

with r24586-f3cdc9f988:

root@router1:~# ifconfig  | grep encap
br-lan    Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
**eth0      Link encap:Ethernet  HWaddr 7E:EE:32:C0:0D:32**
eth1      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
hn2wlan   Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E7
hn5wpa3   Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E6
ifb-dns   Link encap:Ethernet  HWaddr 26:96:D7:32:D4:5A
ifb4wan   Link encap:Ethernet  HWaddr FA:14:12:9C:9A:37
lan1      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lan2      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lan3      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lan4      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lo        Link encap:Local Loopback
**wan       Link encap:Ethernet  HWaddr 7E:EE:32:C0:0D:32**

with my previous build r24368-36b1dd75fd (from mid-November):

root@router1:~# ifconfig  | grep encap
br-lan    Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
eth0      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E5
eth1      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
hn2wlan   Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E7
hn5wpa3   Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E6
ifb-dns   Link encap:Ethernet  HWaddr 9A:AD:7E:E1:29:3D
ifb4wan   Link encap:Ethernet  HWaddr 32:17:33:7C:FF:94
lan1      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lan2      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lan3      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lan4      Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E4
lo        Link encap:Local Loopback
wan       Link encap:Ethernet  HWaddr DC:EF:09:EF:F3:E5

Flash contents:

root@router1:~# hexdump -C -n 18 /dev/mtd3 | head -n 2
00000000  dc ef 09 ef f3 e4 dc ef  09 ef f3 e5 dc ef 09 ef  |................|
00000010  f3 e6                                             |..|

I have not yet tried reverting this commit, but I do not see much other possibilities in the regression range.

EDIT:
like @shelterx said in forum discussion, the wan MAC is now random and changes at each boot:

root@router1:~# ifconfig | grep ^wan.*encap
wan       Link encap:Ethernet  HWaddr 22:62:1F:FE:9C:92

[DragonBluep]

@hnyman here is a mistake. Change this line to nvmem-cells = <&macaddr_art_6 0>; should fix it.

openwrt/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8065-nighthawk.dtsi

Line 430 in f3cdc9f

nvmem-cells = <&macaddr_art_6>;

[hnyman]

Thanks for confirming my own thoughts.
Already test compiling just that change ;-)
Will see if that helps.

--- a/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8065-nighthawk.dtsi
+++ b/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8065-nighthawk.dtsi
@@ -427,7 +427,7 @@
        pinctrl-0 = <&rgmii2_pins>;
        pinctrl-names = "default";
 
-       nvmem-cells = <&macaddr_art_6>;
+       nvmem-cells = <&macaddr_art_6 0>;
        nvmem-cell-names = "mac-address";
 
        fixed-link {

EDIT:
That helped:
wan Link encap:Ethernet HWaddr DC:EF:09:EF:F3:E5