-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
target: ipq806x: remove mac-address-increment #13952
Conversation
1f4b743
to
562aaa4
Compare
ping @computersforpeace |
It's deprecated. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Fixes dtc warnings Signed-off-by: Rosen Penev <rosenp@gmail.com>
Current r24586-f3cdc9f988 build for R7800 reads a wrong MAC address for wan, while lan ports and wlan do have the corrects MACs. I suspect this commit, as it handles the MAC reading from flash. Lan and wlan MACs are ok, but wan (eth0) MAC is wrong. with r24586-f3cdc9f988:
with my previous build r24368-36b1dd75fd (from mid-November):
Flash contents:
I have not yet tried reverting this commit, but I do not see much other possibilities in the regression range. EDIT:
|
@hnyman here is a mistake. Change this line to openwrt/target/linux/ipq806x/files/arch/arm/boot/dts/qcom-ipq8065-nighthawk.dtsi Line 430 in f3cdc9f
|
Thanks for confirming my own thoughts.
EDIT: |
Correct the NVMEM mac-base field usage to read the wan MAC correctly from flash. Reference to discussion at openwrt#13952 (comment) Fixes: d264d3a ("ipq806x: remove mac-address-increment") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Correct the NVMEM mac-base field usage to read the wan MAC correctly from flash. Reference to discussion at openwrt#13952 (comment) Fixes: d264d3a ("ipq806x: remove mac-address-increment") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Correct the NVMEM mac-base field usage to read the wan MAC correctly from flash. Reference to discussion at openwrt#13952 (comment) Fixes: d264d3a ("ipq806x: remove mac-address-increment") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Correct the NVMEM mac-base field usage to read the wan MAC correctly from flash. Reference to discussion at openwrt#13952 (comment) Fixes: d264d3a ("ipq806x: remove mac-address-increment") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Correct the NVMEM mac-base field usage to read the wan MAC correctly from flash. Reference to discussion at openwrt#13952 (comment) Fixes: d264d3a ("ipq806x: remove mac-address-increment") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
Correct the NVMEM mac-base field usage to read the wan MAC correctly from flash. Reference to discussion at openwrt#13952 (comment) Fixes: d264d3a ("ipq806x: remove mac-address-increment") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
It's deprecated.
ping @rmilecki @Ansuel