Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: fix compile error on some systems #15441

Merged
merged 1 commit into from
May 13, 2024

Conversation

zpc0
Copy link
Contributor

@zpc0 zpc0 commented May 10, 2024

On Fedora 40, -Wimplictit-function-declaration error is occur when compiling audit package.

Upstream fixed this problem, so backport the patch.
linux-audit/audit-userspace#371

@github-actions github-actions bot added the core packages pull request/issue for core (in-tree) packages label May 10, 2024
@neheb
Copy link
Contributor

neheb commented May 10, 2024

make package/audit/{clean,refresh}

@zpc0
Copy link
Contributor Author

zpc0 commented May 11, 2024

make package/audit/{clean,refresh}

Thank you for review! I performed refresh.

@robimarko
Copy link
Contributor

I cannot reproduce this on Fedora 40, but the fix seems legit.

@neheb
Copy link
Contributor

neheb commented May 12, 2024

I can reproduce on Fedora 40. This fixes it.

edit: this is also needed for GCC14 that was recently commited.

On Fedora 40, -Wimplictit-function-declaration error
is occur when compiling audit package.

Upstream fixed this problem, so backport the patch.
linux-audit/audit-userspace#371

Signed-off-by: Yanase Yuki <dev@zpc.st>
Link: openwrt#15441
Signed-off-by: Robert Marko <robimarko@gmail.com>
@openwrt-bot openwrt-bot merged commit f1b4fc4 into openwrt:main May 13, 2024
1 check passed
@robimarko
Copy link
Contributor

Thanks! Rebased on top of main and merged!

@zpc0 zpc0 deleted the audit-fix-printf branch May 13, 2024 09:10
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request May 18, 2024
On Fedora 40, -Wimplictit-function-declaration error
is occur when compiling audit package.

Upstream fixed this problem, so backport the patch.
linux-audit/audit-userspace#371

Signed-off-by: Yanase Yuki <dev@zpc.st>
Link: openwrt#15441
Signed-off-by: Robert Marko <robimarko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants