Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: ext4: increase x86 rootfs size for online resize #1669

Closed
wants to merge 1 commit into from
Closed

config: ext4: increase x86 rootfs size for online resize #1669

wants to merge 1 commit into from

Conversation

bobafetthotmail
Copy link
Contributor

@bobafetthotmail bobafetthotmail commented Dec 23, 2018

ext4 online resize on x86 rootfs fails unless the rootfs size is set to 2 GB or larger,
this is very inconvenient because the only way to increase
filesystem size is to do it with the filesystem unmounted.

This is an example of the error when I try to resize it when mounted from my PC
(this is the same error I get also in OpenWrt)


alby@openSUSE-xeon:/> sudo resize2fs /dev/sdd2
resize2fs 1.44.4 (18-Aug-2018)
Filesystem at /dev/sdd2 is mounted on /run/media/alby/57f8f4bc-abf4-655f-bf67-946fc0f9f25b; on-line resizing required
old_desc_blocks = 1, new_desc_blocks = 1
resize2fs: Invalid argument While checking for on-line resizing support


This commit restores commit dc6cc04
which was reverted later in commit 4cc1f1a
imho (also reading the description) the revert was a mistake.
"2 GB is overkill and was only added to allow unlimited ext4 resizing,
which is a pretty rare use case. "

That commit was not about allowing unlimited resizing.
The issue here is that online resize does not work
unless the filesystem size is 2GB or more,
or maybe if we change the block size instead.

Signed-off-by: Alberto Bursi alberto.bursi@outlook.it

ext4 online resize on x86 rootfs fails unless the rootfs size is set to 2 GB or larger, 
this is very inconvenient because the only way to increase 
filesystem size is to do it with the filesystem unmounted.

This is an example of the error when I try to resize it when mounted from my PC
(this is the same error I get also in OpenWrt)
-------
alby@openSUSE-xeon:/> sudo resize2fs /dev/sdd2
resize2fs 1.44.4 (18-Aug-2018)
Filesystem at /dev/sdd2 is mounted on /run/media/alby/57f8f4bc-abf4-655f-bf67-946fc0f9f25b; on-line resizing required
old_desc_blocks = 1, new_desc_blocks = 1
resize2fs: Invalid argument While checking for on-line resizing support
-------

This commit restores commit dc6cc04
which was reverted later in commit 4cc1f1a
imho (also reading the description) the revert was a mistake.
"2 GB is overkill and was only added to allow unlimited ext4 resizing,
which is a pretty rare use case. "

That commit was not about allowing unlimited resizing.
The issue here is that online resize does not work 
unless the filesystem size is 2GB or more, 
or maybe if we change the block size instead.

Signed-off-by: Alberto Bursi <alberto.bursi@outlook.it>
@bobafetthotmail
Copy link
Contributor Author

@nbd168 @jow- @mhei

@dedeckeh dedeckeh added the build/scripts/tools pull request/issues for build, scripts and tools related changes label Dec 24, 2018
@diizzyy
Copy link
Contributor

diizzyy commented Mar 14, 2019

Out of curiosity, why not just add another parition?

@bobafetthotmail
Copy link
Contributor Author

Out of curiosity, why not just add another parition?

You mean doing an extroot in a new partition? No it did not work when I tried. I could not even do it manually (i.e. mounting another partition over /overlay). Does it work for you?

Still, even if it worked, I think it's stupid to require an extroot because you can't provide an expandable image.

@diizzyy
Copy link
Contributor

diizzyy commented Mar 14, 2019

Unless you're using out of tree packages filling up 256Mbyte is quite a "challange"? :-)

@ynezz
Copy link
Member

ynezz commented Mar 24, 2019

It seems like nobody is interested in merging this. I find 2GiB images just to be able to do online resizing quite excessive. I would just use squashfs+ext4.

@peterwillcn
Copy link
Contributor

peterwillcn commented Apr 12, 2020

@ynezz The container needs more space, and I feel this partition is fine
Not in the last century. Hardware is cheap, and bulk storage is common

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/scripts/tools pull request/issues for build, scripts and tools related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants