Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar71xx: improve support for Arduino Yun #3188

Closed
wants to merge 4 commits into from
Closed

ar71xx: improve support for Arduino Yun #3188

wants to merge 4 commits into from

Conversation

mans0n
Copy link
Member

@mans0n mans0n commented Jul 8, 2020

Resubmission of https://patchwork.ozlabs.org/project/openwrt/list/?series=162629

This patchset fixes some bugs for Arduino Yun, which have been lying around for years.

  • Revert "ar71xx: fix Arduino Yun enabling of level shifters outputs"
  • ar71xx: fix sysupgrade for Arduino Yun
  • ar71xx: enable ethernet LED of Arduino Yun
  • ar71xx: restore support for boot console with arbitrary baud rates

@mans0n
Revert "ar71xx: fix Arduino Yun enabling of level shifters outputs"
ea4aaf6 
This reverts commit 077253d.

The output enable pins should be disabled by default, and only enabled when
used. Otherwise unwanted conflicts might occur between MCU and SoC pins.

Signed-off-by: Sungbo Eo <mans0n@gorani.run>
@mans0n
ar71xx: fix sysupgrade for Arduino Yun
d864710 
Commit bb46b63 changed its partition scheme, but sysupgrade image
validation still uses the old format. This commit fixes it so that
force flag is not needed for sysupgrade.

Fixes: bb46b63 ("ar71xx: move Arduino Yun to generic building code")
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
@mans0n
ar71xx: enable ethernet LED of Arduino Yun
2da06a9 
Commit 05d73a2 enabled GPIO on ethernet LED, but proper LED setup was
not added then. This commit fixes it by reverting the change on the LED.

Fixes: 05d73a2 ("ar71xx: Arduino Yun board 'WLAN RST' button support")
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
@mans0n
ar71xx: restore support for boot console with arbitrary baud rates
38ab6c5 
Commit 1bfbf2d ("ar71xx: serial: core: add support for boot console
with arbitrary baud rates") added support for arbitrary baud rates which
enabled 250000 baud rate for Yun. But the patch was not ported to kernel
4.9, and since then the kernel set its baud rate to 9600. This commit ports
the patch to kernel 4.14, thereby restoring the serial console of Yun.

Cc: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Sungbo Eo <mans0n@gorani.run>
@mans0n mans0n mentioned this pull request Jul 8, 2020
Closed
@ynezz ynezz added the target/ar71xx pull request/issue for ar71xx target label Jul 9, 2020
@wvdakker wvdakker mentioned this pull request Jul 9, 2020
Closed
@aparcar
Copy link
Member

aparcar commented Jul 18, 2020

Isn't ar71xx meant to slowly fade away?

@adschm
Copy link
Member

adschm commented Jul 18, 2020

Isn't ar71xx meant to slowly fade away?

Yes, but that doesn't mean that it's not allowed to fix things there which are broken.

@adschm adschm added the fix pull request contains fix for some issue label Jul 18, 2020
@isantolin
Copy link

Anyone can merge?

@adschm
Copy link
Member

adschm commented Aug 2, 2020

@mans0n I merged patches 1-3. I really can't judge on patch 4, particularly as that's not limited to a single device like the others.

I recommend to either live with the probable outcome that nobody will care about it or try a resubmission to the mailing list.

I will close this now, as keeping the separate fourth patch under that PR title won't help.

Should I backport the three patches to 18.06 as well?

@adschm adschm closed this Aug 2, 2020
@mans0n mans0n deleted the pr-yun-ar71xx branch August 2, 2020 15:18
@mans0n
Copy link
Member Author

mans0n commented Aug 2, 2020 •
edited
Loading

I merged patches 1-3.

Thanks. :)

I really can't judge on patch 4, particularly as that's not limited to a single device like the others.

It has already been merged in ath79 target, so I think merging the ar71xx patch wouldn't do much more harm.
Either way is fine with me, I won't really use it anyway.

I recommend to either live with the probable outcome that nobody will care about it or try a resubmission to the mailing list.

Resubmitting it thrice? xD I'm done here.

Should I backport the three patches to 18.06 as well?

Yes, especially the sysupgrade patch.

@isantolin
Copy link

@mans0n @adrianschmutzler @ynezz Hi to all!
Anyone has decent instructions to upgrade Arduino Yun to the last OpenWRT version?

@mans0n
Copy link
Member Author

mans0n commented Aug 2, 2020 •
edited
Loading

@isantolin Maybe this will help you? 358aec7

@adschm
Copy link
Member

adschm commented Aug 2, 2020

I really can't judge on patch 4, particularly as that's not limited to a single device like the others.

It has already been merged in ath79 target, so I think merging the ar71xx patch wouldn't do much more harm.
Either way is fine with me, I won't really use it anyway.

Ah, that makes it easy for me. I merged that patch as well and backported ar71xx together with ath79 patch for consistency to 4.14.

Should I backport the three patches to 18.06 as well?

Yes, especially the sysupgrade patch.

I backported them, but did not backport patch 4 as that's another kernel again.

So, we should be done here ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix pull request contains fix for some issue target/ar71xx pull request/issue for ar71xx target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mans0n @aparcar @adschm @isantolin @ynezz