Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncdu Makefile needs tabs #137

Closed
ajd4096 opened this issue Jul 28, 2014 · 3 comments
Closed

ncdu Makefile needs tabs #137

ajd4096 opened this issue Jul 28, 2014 · 3 comments

Comments

@ajd4096
Copy link

ajd4096 commented Jul 28, 2014

make[2]: Entering directory `/exports/pub/OpenWRT/trunk/feeds/packages/utils/ncdu'
Makefile:46: *** missing separator. Stop.

diff --git a/utils/ncdu/Makefile b/utils/ncdu/Makefile
index 425d30e..edd8527 100644
--- a/utils/ncdu/Makefile
+++ b/utils/ncdu/Makefile
@@ -39,8 +39,8 @@ define Package/ncdu/description
 endef

 define Package/ncdu/install
-  $(INSTALL_DIR) $(1)/usr/bin
-  $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/ncdu $(1)/usr/bin/
+       $(INSTALL_DIR) $(1)/usr/bin
+       $(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/ncdu $(1)/usr/bin/
 endef

 $(eval $(call BuildPackage,ncdu))
@champtar
Copy link
Member

@ajd4096, thanks for reporting, please make a pull request next time

champtar added a commit that referenced this issue Jul 29, 2014
this fixes #137

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
@champtar
Copy link
Member

also @clehner, please compile test your commits next time...

@clehner
Copy link
Contributor

clehner commented Jul 29, 2014

Woops, I didn't realize the Makefile was whitespace sensitive. It compiled for me without error, with GNU Make 4.0-8 on Debian testing. I had assumed it was a mistake to combine tabs and spaces for indentation, but now that I look at more packages, I see it is common to use tabs in the install sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants