Revert "net/miniupnpd: ext_ip_reserved_ignore support" #16152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is causing several issues [1], which then were reported to upstream [2] and it was not accepted by upstream [3]. This results that nobody maintain this custom patch and it is not useful as it is changing addr_is_reserved behavior. [1] openwrt#15258 [2] miniupnp/miniupnp#542 [3] miniupnp/miniupnp#511 This reverts commit b76aa99. Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: noone
Compile tested: N/A
Run tested: N/A
Description:
This patch is causing several issues [1], which then were reported to
upstream [2] and it was not accepted by upstream [3]. This results that
nobody maintain this custom patch and it is not useful as it is changing
addr_is_reserved behavior.
[1] #15258
[2] miniupnp/miniupnp#542
[3] miniupnp/miniupnp#511
This reverts commit b76aa99.
I will cherry-pick this also to OpenWrt 21.02.
This should be reverted earlier once issues appeared like this #14031
CC: @pali