Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniupnpd: multiple unhelpful messages in the log #15258

Closed
stangri opened this issue Mar 25, 2021 · 7 comments
Closed

miniupnpd: multiple unhelpful messages in the log #15258

stangri opened this issue Mar 25, 2021 · 7 comments

Comments

@stangri
Copy link
Member

stangri commented Mar 25, 2021

Maintainer: @neheb
Environment: x86-64, Sophos SG-105, 21.02-SNAPSHOT r15926

Description:

I keep seeing the messages like below in the log. Is it missing a d at the end (as in checking is ignored)? There's no indication on why is it being reported or what caused it. Is it possible to improve this message to make it more clear?

00:11:33 miniupnpd[5981]: private/reserved address checking is ignore
00:11:33 miniupnpd[5981]: private/reserved address checking is ignore
00:11:33 miniupnpd[5981]: private/reserved address checking is ignore
00:17:38 miniupnpd[5981]: private/reserved address checking is ignore
00:17:39 miniupnpd[5981]: private/reserved address checking is ignore
00:17:39 miniupnpd[5981]: private/reserved address checking is ignore
00:35:23 miniupnpd[5981]: private/reserved address checking is ignore
00:35:24 miniupnpd[5981]: private/reserved address checking is ignore
00:35:24 miniupnpd[5981]: private/reserved address checking is ignore
@neheb
Copy link
Contributor

neheb commented Mar 25, 2021

I don't really maintain this. It looks like some upstream bug.

@stangri stangri closed this as completed Mar 26, 2021
@pali
Copy link
Contributor

pali commented Apr 27, 2021

@neheb: this change is not part of upstream and it was accepted into openwrt by you.

Moreover this patch is incorrect and and is breaking upnp protocol as desribed in comments.

So please do not instruct users to forward openwrt bugs and issues to upstream projects like it already happened because upstream developers really do not have a time to investigate issues caused by downstream openwrt patches.

@pali pali mentioned this issue Apr 27, 2021
Closed
@BKPepe BKPepe reopened this Apr 27, 2021
@stangri
Copy link
Member Author

stangri commented Apr 28, 2021 •
edited
Loading

@ptpt52 -- can you please advise me why have I started seeing these messages in the log? What do they mean? Why is the default setting on for these?

@stangri stangri mentioned this issue Jun 1, 2021
Merged
@ptpt52 ptpt52 mentioned this issue Jul 2, 2021
Closed
@ptpt52
Copy link
Contributor

ptpt52 commented Jul 2, 2021

I am trying to drop this option, Please help test #16011

BKPepe added a commit to BKPepe/packages that referenced this issue Jul 19, 2021
@BKPepe
Revert "net/miniupnpd: ext_ip_reserved_ignore support"
107f337 
This patch is causing several issues [1], which then were reported to
upstream [2] and it was not accepted by upstream [3]. This results that
nobody maintain this custom patch and it is not useful as it is changing
addr_is_reserved behavior.

[1] openwrt#15258
[2] miniupnp/miniupnp#542
[3] miniupnp/miniupnp#511

This reverts commit b76aa99.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
@BKPepe BKPepe mentioned this issue Jul 19, 2021
Merged
BKPepe added a commit that referenced this issue Jul 20, 2021
@BKPepe
Revert "net/miniupnpd: ext_ip_reserved_ignore support"
5e69e41 
This patch is causing several issues [1], which then were reported to
upstream [2] and it was not accepted by upstream [3]. This results that
nobody maintain this custom patch and it is not useful as it is changing
addr_is_reserved behavior.

[1] #15258
[2] miniupnp/miniupnp#542
[3] miniupnp/miniupnp#511

This reverts commit b76aa99.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
(cherry picked from commit 107f337)
nirizr pushed a commit to nirizr/packages that referenced this issue Jul 20, 2021
@BKPepe @nirizr
Revert "net/miniupnpd: ext_ip_reserved_ignore support"
75dad3c 
This patch is causing several issues [1], which then were reported to
upstream [2] and it was not accepted by upstream [3]. This results that
nobody maintain this custom patch and it is not useful as it is changing
addr_is_reserved behavior.

[1] openwrt#15258
[2] miniupnp/miniupnp#542
[3] miniupnp/miniupnp#511

This reverts commit b76aa99.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
BKPepe added a commit that referenced this issue Aug 28, 2021
@BKPepe
Revert "net/miniupnpd: ext_ip_reserved_ignore support"
b35c398 
This patch is causing several issues [1], which then were reported to
upstream [2] and it was not accepted by upstream [3]. This results that
nobody maintain this custom patch and it is not useful as it is changing
addr_is_reserved behavior.

[1] #15258
[2] miniupnp/miniupnp#542
[3] miniupnp/miniupnp#511

This reverts commit b76aa99.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
(cherry picked from commit 107f337)
@Neustradamus
Copy link

There is a new patch from @ptpt52:

It replaces the old 301-ext_ip_reserved_ignore.patch.

Tested by @openips!

utoni pushed a commit to utoni/openwrt-packages that referenced this issue Jan 21, 2022
@BKPepe @utoni
Revert "net/miniupnpd: ext_ip_reserved_ignore support"
1e03a1a 
This patch is causing several issues [1], which then were reported to
upstream [2] and it was not accepted by upstream [3]. This results that
nobody maintain this custom patch and it is not useful as it is changing
addr_is_reserved behavior.

[1] openwrt#15258
[2] miniupnp/miniupnp#542
[3] miniupnp/miniupnp#511

This reverts commit b76aa99.

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
@tiagogaspar8
Copy link
Contributor

Hi @stangri, is this still vaild?

@stangri
Copy link
Member Author

stangri commented Aug 25, 2022

I no longer use miniupnpd, not sure if this issue persists.

@stangri stangri closed this as completed Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Neustradamus @neheb @BKPepe @stangri @ptpt52 @pali @tiagogaspar8