Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksmbd-tools: going to apk #23750

Closed
wants to merge 0 commits into from
Closed

ksmbd-tools: going to apk #23750

wants to merge 0 commits into from

Conversation

pesa1234
Copy link
Contributor

@pesa1234 pesa1234 commented Mar 25, 2024

Solved strange package version 0~ to match apk format.

Maintainer: nobody
Compile tested: mediatek/filogic GL.iNet GL-MT6000 OpenWRT snapshot r25663-ce0cf80dac

Run tested: mediatek/filogic GL.iNet GL-MT6000 OpenWRT snapshot r25663-ce0cf80dac
Tested
-add new user
-mod existing user

Description:
Previous version
ksmbd-avahi-service 0~3.5.1-r1
ksmbd-hotplug 0~3.5.1-r1
ksmbd-server 0~3.5.1-r1

Actual:
ksmbd-avahi-service 3.5.1-r2
ksmbd-hotplug 3.5.1-r2
ksmbd-server 3.5.1-r2

PKG_SOURCE_URL:=https://github.com/cifsd-team/ksmbd-tools
PKG_SOURCE_VERSION:=3.5.1
PKG_MIRROR_HASH:=6e8e56ecdfa0ddfdb3a351b27ae5b9148d4f6695bcee9a7eae39c2a42481ef18
PKG_RELEASE:=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make consistent with other packages please

PKG_NAME
PKG_VERSION
PKG_RELEASE

PKG_SOURCE
PKG_SOURCE_URL
PKG_HASH

Copy link
Contributor Author

@pesa1234 pesa1234 Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I have update it as other packages. Let me know if it is ok.

Thanks

@neheb
Copy link
Contributor

neheb commented Mar 30, 2024

@pesa1234 squash to a single commit and change the commit name. Maybe

kmsbd-tools: fix version after apk changes

@pesa1234
Copy link
Contributor Author

@pesa1234 squash to a single commit and change the commit name. Maybe

kmsbd-tools: fix version after apk changes

How can I do it without close and reopen? Sorry but I'm a newbie and I didn't find a guide.

Thanks

@pesa1234 pesa1234 closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants