libnopoll: noPoll C WebSocket library 0.4.2

[inindev]

Maintainer: John Clark inindev@gmail.com / @inindev
Compile tested: ar71xx, gl-inet-6416A-v1, LEDE trunk
Run tested: ar71xx, gl-inet-6416A-v1, library integration test

Description: noPoll C WebSocket library 0.4.2
http://www.aspl.es/nopoll

Signed-off-by: John Clark inindev@gmail.com
Tested-by: John Clark inindev@gmail.com

[diizzyy]

Use release tarballs instead of git if available (which is available in this case)

Looks good in general otherwise

Best regards, Daniel

[inindev]

The reason I didn't use the release tarball is that it is named 0.4.2.tar.gz and wondered about a conflict in the dl directory. When pulling from git I am able to specify that it be named --.tar.gz. Should I not worry about this?
(tag 0.4.2 is commit 60a81fbd199551ac5dd017b9a44fb46e8530680b)

tarball: lede-project/source/dl/0.4.2.tar.gz

git: lede-project/source/dl/nopoll-0.4.2-60a81fbd199551ac5dd017b9a44fb46e8530680b.tar.gz


[diizzyy]

Ahh, nevermind... It also relies on Githubs "on-the-fly" compression system so tarball checksum will change. Sorry for not noticing and sorry for the noise.

It looks fine otherwise, please change gz to xz however :-)

[inindev]

good call on the xz compression

[karlp]

@diizzyy where does the guidelines on "not using git" come from? I've not seen that anywhere recommended as a formal guideline.

[diizzyy]

It isn't however it's a reasonable suggestion since git (checkout) packages for now aren't reproducible which is bad for availability since you cannot mirror those.

[inindev]

If the PR is looks reasonable, who does the actual commit?