-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] bot,stale: add stale plugin config #7279
Conversation
https://probot.github.io/apps/stale/ Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
daysUntilClose: 15 | ||
# Issues with these labels will never be considered stale | ||
exemptLabels: | ||
- security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's gone 45 days with no action, it's not really a "security" issue is it? :)
@@ -0,0 +1,19 @@ | |||
# Number of days of inactivity before an issue becomes stale | |||
daysUntilStale: 45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather see this more like 90 and 30, but that's really just bikeshedding I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my idea is 2 fold:
- send a remainder that this issue / PR need actions, so the sooner the better
- when it's really stale close it
Closing is not a death sentence, we can reopen
Also a new comment restart the stale counter, if nobody comment for 60 days I think we can call that stale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sold :)
Any time-frame is better than none. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@champtar thanks!
In all honestly, the majority of open PRs are either:
I don't think we're doing anyone favors especially closing PRs to hide the underlying issues, it also discourages people to contribute if they don't receive a human reply with a reasonable argument. I personally don't like the mass PRs without any run tests (or at least mentioned ones). These should not be submitted in the first place but that's just my personal opinion as it more or less just piles up. Closing because of submitter timeout is fine but that only applies to a very small amount of open PRs. |
@champtar I find it very useful, especially for issue reporting that lacks bare minimum information like maintainer, logs etc. Thanks! |
I guess we can close this now? |
...I guess so |
We have a lot of stale issues and PR
Let's automatically close them so we can concentrate on the active ones
https://probot.github.io/apps/stale/