Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] bot,stale: add stale plugin config #7279

Closed
wants to merge 1 commit into from

Conversation

champtar
Copy link
Member

We have a lot of stale issues and PR
Let's automatically close them so we can concentrate on the active ones
https://probot.github.io/apps/stale/

https://probot.github.io/apps/stale/

Signed-off-by: Etienne Champetier <champetier.etienne@gmail.com>
daysUntilClose: 15
# Issues with these labels will never be considered stale
exemptLabels:
- security
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's gone 45 days with no action, it's not really a "security" issue is it? :)

@@ -0,0 +1,19 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see this more like 90 and 30, but that's really just bikeshedding I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my idea is 2 fold:

  1. send a remainder that this issue / PR need actions, so the sooner the better
  2. when it's really stale close it
    Closing is not a death sentence, we can reopen
    Also a new comment restart the stale counter, if nobody comment for 60 days I think we can call that stale

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sold :)

@thess
Copy link
Member

thess commented Oct 31, 2018

Any time-frame is better than none.
Good idea - let's do it.

Copy link
Member

@lynxis lynxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@champtar thanks!

@diizzyy
Copy link
Contributor

diizzyy commented Nov 2, 2018

In all honestly, the majority of open PRs are either:

  1. Adding new software and no one with commit access wants to actually decide whether to add it or not 2. PRs without any run-tests

I don't think we're doing anyone favors especially closing PRs to hide the underlying issues, it also discourages people to contribute if they don't receive a human reply with a reasonable argument.

I personally don't like the mass PRs without any run tests (or at least mentioned ones). These should not be submitted in the first place but that's just my personal opinion as it more or less just piles up.

Closing because of submitter timeout is fine but that only applies to a very small amount of open PRs.

@dibdot
Copy link
Contributor

dibdot commented Nov 4, 2018

@champtar I find it very useful, especially for issue reporting that lacks bare minimum information like maintainer, logs etc. Thanks!

@diizzyy
Copy link
Contributor

diizzyy commented Jul 14, 2019

I guess we can close this now?

@diizzyy
Copy link
Contributor

diizzyy commented Aug 1, 2019

...I guess so

@diizzyy diizzyy closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants